[Qgis-developer] Legend refactoring branch merged

[Larry Shaffer]

Hi Martin,

Thanks for your work on this and for the sponsors that supported it!

Couples things I noticed:

* There is no longer and indication that a layer is in edit mode, or not,
i.e. the edit pencil icon, and its relative states (red or yellow), is gone.

* There is no longer an indication of the active layer, previously the one
underlined. This is different than the currently selected layer(s). The
underline would persist with no selection, or multiple selections, and
would mirror the view's currentItem(), or in maybe now currentIndex(). When
iface.activeLayer() is used in console, it should return the identical
layer in the legend that is underlined, or otherwise indicated as active.

* Something is funky with the connections between the legend and the
Current Edits functionality. After a layer is no layers are editable
anymore, the submenu is still active, offering to cancel edits. I added
that code, and can investigate more after the feature freeze.

* There is no longer a tool tip when hovering over the layer, showing the
layer's source definition.

* When opening one project, QGIS crashed with the following (project never
loads):

Exception Type:  EXC_BAD_ACCESS (SIGSEGV)
Exception Codes: KERN_INVALID_ADDRESS at 0x0000000000000010

0   org.qgis.qgis2_core  QgsSymbolV2::drawPreviewIcon(QPainter*, QSize) +
42 (qlist.h:99)
1   org.qgis.qgis2_core
QgsSymbolLayerV2Utils::symbolPreviewPixmap(QgsSymbolV2*, QSize) + 114
(qgssymbollayerv2utils.cpp:517)
2   org.qgis.qgis2_gui
QgsLayerTreeModel::addSymbologyToVectorLayer(QgsLayerTreeLayer*) + 570
(qgslayertreemodel.cpp:520)
3   org.qgis.qgis2_gui
QgsLayerTreeModel::addSymbologyToLayer(QgsLayerTreeLayer*) + 88
(qgslayertreemodel.cpp:480)
4   QtCore                      QMetaObject::activate(QObject*, QMetaObject
const*, int, void**) + 2141
5   org.qgis.qgis2_core
QgsLayerTreeLayer::registryLayersAdded(QList<QgsMapLayer*>) + 307
(qgslayertreelayer.cpp:145)
6   org.qgis.qgis2_core  QgsLayerTreeLayer::qt_static_metacall(QObject*,
QMetaObject::Call, int, void**) + 172 (qlist.h:731)

Regards,

Larry
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osgeo.org/pipermail/qgis-developer/attachments/20140521/08c9f6d5/attachment.html>