[Qgis-developer] Legend refactoring branch merged

[Martin Dobias]

Hi Larry

On Thu, May 22, 2014 at 2:39 AM, Larry Shaffer <larrys at dakotacarto.com> wrote:
> Hi Martin,
>
> Thanks for your work on this and for the sponsors that supported it!
>
> Couples things I noticed:
>
> * There is no longer and indication that a layer is in edit mode, or not,
> i.e. the edit pencil icon, and its relative states (red or yellow), is gone.
>
> * There is no longer an indication of the active layer, previously the one
> underlined. This is different than the currently selected layer(s). The
> underline would persist with no selection, or multiple selections, and would
> mirror the view's currentItem(), or in maybe now currentIndex(). When
> iface.activeLayer() is used in console, it should return the identical layer
> in the legend that is underlined, or otherwise indicated as active.
>
> * Something is funky with the connections between the legend and the Current
> Edits functionality. After a layer is no layers are editable anymore, the
> submenu is still active, offering to cancel edits. I added that code, and
> can investigate more after the feature freeze.
>
> * There is no longer a tool tip when hovering over the layer, showing the
> layer's source definition.

Thanks a lot for the feedback. Will address that shortly.


> * When opening one project, QGIS crashed with the following (project never
> loads):
>
> Exception Type:  EXC_BAD_ACCESS (SIGSEGV)
> Exception Codes: KERN_INVALID_ADDRESS at 0x0000000000000010
>
> 0   org.qgis.qgis2_core  QgsSymbolV2::drawPreviewIcon(QPainter*, QSize) + 42
> (qlist.h:99)
> 1   org.qgis.qgis2_core
> QgsSymbolLayerV2Utils::symbolPreviewPixmap(QgsSymbolV2*, QSize) + 114
> (qgssymbollayerv2utils.cpp:517)
> 2   org.qgis.qgis2_gui
> QgsLayerTreeModel::addSymbologyToVectorLayer(QgsLayerTreeLayer*) + 570
> (qgslayertreemodel.cpp:520)
> 3   org.qgis.qgis2_gui
> QgsLayerTreeModel::addSymbologyToLayer(QgsLayerTreeLayer*) + 88
> (qgslayertreemodel.cpp:480)
> 4   QtCore                      QMetaObject::activate(QObject*, QMetaObject
> const*, int, void**) + 2141
> 5   org.qgis.qgis2_core
> QgsLayerTreeLayer::registryLayersAdded(QList<QgsMapLayer*>) + 307
> (qgslayertreelayer.cpp:145)
> 6   org.qgis.qgis2_core  QgsLayerTreeLayer::qt_static_metacall(QObject*,
> QMetaObject::Call, int, void**) + 172 (qlist.h:731)

Oh, sorry about that. Something must have gone wrong with a vector
layer's symbol. I can't see where the problem could be straight away -
would it be possible for you to send me the project file - or see if
you can provide more information how to replicate the problem?

Regards
Martin