[Qgis-developer] Virtual Fields - Allow adding fields out of edit mode

[Bernhard Ströbl]

Hi Matthias

Am 07.10.2014 14:06, schrieb Matthias Kuhn:
> Thank you for testing Bernhard,
>
>
> On 07.10.2014 10:06, Bernhard Ströbl wrote:
>> Hi Matthias,
>>
>> there seems to be a small bug in the add field stuff: scenario
>> 1) add a virtual field
>> 2) add a permanent field => field is added but marked as virtual
>> (symbol) and name is that of the virtual field added in step 1) BUG!
>> 3) close and reopen layer properties => field from step 2) is
>> displayed as it should, so the bug is on the display side only
>
> Could you open an issue report for this so we don't forget? Thank you.

done : http://hub.qgis.org/issues/11342
I assigned it to you
>
>>
>> tested with e5850f3
>>
>> to your question: I think the current editing-mode behavior is
>> intuitive. What is not intuitive is that the expression editor can
>> only be launched when adding a virtual field. I am aware that I can
>> add a (permanent) field with the field calculator but this whole
>> business is IMHO not consistent.
>> This would be consistent:
>> 1) in field calculator if choosing to add a new field offer to make it
>> virtual or permanent (permanent being default)
>
> It could go there indeed, good idea.

will the field calcuator be active all the time then?
just thinking of consequences....

>
>> 2) make add-field dialog be the same no matter if adding a permanent
>> or virtual field.
>
> I don't completely follow. Do you propose to remove the "virtual field"
> from the "add field" in favor of 1) or is the intention something else?

no, proposals 1) and 2) are independent from each other.
proposal 2) means, that the expression builder should be offered when 
adding a permanent field, too, thus not changing the dialog when user 
changes his choice of permanent/virtual.
Scenario is: user wants to add a permanent field and fill it with an 
expression. Now it is either
1) add field and accept
2) open calculator, choose field
3) define expression and accept
or:
1) set editable
2) open calculator
3) define expression and accept

future behaviour would be:
1) add field
2) define expression and accept

Bernhard

>
> Best
> Matthias
>


__________ Information from ESET Mail Security, version of virus signature database 10524 (20141007) __________

The message was checked by ESET Mail Security.
http://www.eset.com