[Qgis-developer] Please stop spamming commit logs!

[Victor Olaya]

I personally do not see any problem in having a "Sponsored by" bottom line
even in every commit message. Maybe not the most correct thing to do, but
it doesn't bother me, just like it doesn't bother me to see the author of
the commit. As long as the first line of the message (which is the one
shown in log summaries) describes the change introduced by the commit, i
think it does no harm at all

If we do not want the log commit to be flooded with such lines, maybe we
can encourage people to put them only in merge commits. If someone is
sponsoring you to develop some new functionality, you are likely going to
be working on it on a separate branch. Write your comments normally and
when it gets merged into master, put your "Sponsored by XXX" tag in the
merge commit.

My 2 cents

Anyway, not such a big problem, IMHO


2014-10-10 12:04 GMT+02:00 Alessandro Pasotti <apasotti at gmail.com>:

> 2014-10-10 11:58 GMT+02:00 Matthias Kuhn <matthias.kuhn at gmx.ch>:
> > Do we have a problem? What kind of?
> >
>
> There was an IF condition in front of my sentence:
>
> IF every developer starts .....
>
> THEN we have a problem
>
> And the problem would be flooding of commit logs with "Funded|Sponsored by
> ..."
>
> I can live with it, I just feel that commit logs are not the right
> place to store those information.
>
> If commit logs were not visible on github (and Google couldn't find
> them) we were probably not even talking about them.
>
> --
> Alessandro Pasotti
> w3:   www.itopen.it
> _______________________________________________
> Qgis-developer mailing list
> Qgis-developer at lists.osgeo.org
> http://lists.osgeo.org/mailman/listinfo/qgis-developer
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osgeo.org/pipermail/qgis-developer/attachments/20141010/6818e421/attachment.html>