[Qgis-developer] Please stop spamming commit logs!

Mon Oct 13 05:01:23 PDT 2014

Hi Jonathan,

I don't think that this is the message that QGIS wants to spread. If it
would be, we would do popups that ask you to sponsor for every new
feature you created ;-)

But as you state, sponsorship is a means to an end. As such it is a
prerequisite for moving this software on and therefore it is good if
users are aware of the fact, that this software was created by people
and that they can only spend their time if they have a possibility to
get the money they need for a living.

If you ask me: a "funded by" is in a commit author's responsibility. He
knows what he wrote that commit for. Be it for money, for fun, for his
boss, somebody he loves or a university degree. If he thinks it is worth
putting a note there for any reason - i.e. definitely not limited to
monetary transactions - he should be able to do so. It does no harm, but
may be a reward for his time or be part of a contract.

The username next to a git commit is not the same thing. It can only
tell who does the commit, but does not tell for what reason/who he does it.

The only restriction I would put to this is that it must be placed at
the end of the commit on a new line (for the sake of good readability).

Regards,
Matthias

On 13.10.2014 11:31, Jonathan Moules wrote:
>
> Hi Larry,
>
> At the risk of being a dissenting voice, is this really the message
> QGIS wants to spread? That sponsorship is king? As an Open Source GIS
> project, I would hope that its prowess lay in producing exceptional GI
> software rather than finding sponsorship. The later is a means to an end.
>
>  
>
> Also, what qualifies as “funded by”? There was a monetary transaction?
> In which case what about the people who donate code they created in
> their own time and have received no fiscal incentive at all – should
> not their contributions be similarly highlighted?
>
>  
>
> Cheers,
>
> Jonathan
>
>  
>
>  
>
> *From:*qgis-developer-bounces at lists.osgeo.org
> [mailto:qgis-developer-bounces at lists.osgeo.org] *On Behalf Of *Larry
> Shaffer
> *Sent:* Saturday, October 11, 2014 12:58 AM
> *To:* Alessandro Pasotti
> *Cc:* QGIS Developer Mailing List
> *Subject:* Re: [Qgis-developer] Please stop spamming commit logs!
>
>  
>
> Hi Alessandro,
>
>  
>
> On Fri, Oct 10, 2014 at 6:57 AM, Alessandro Pasotti
> <apasotti at gmail.com <mailto:apasotti at gmail.com>> wrote:
>
> 2014-10-10 14:44 GMT+02:00 Jürgen E. <jef at norbit.de
> <mailto:jef at norbit.de>>:
> > Hi Matthias,
> >
> > On Fri, 10. Oct 2014 at 11:53:28 +0200, Matthias Kuhn wrote:
> >> To make an example, this is a good commit message.
> >>
> >>
> https://github.com/qgis/QGIS/commit/a132bc9a9e318c2321c8fba13dc9503b4d11e2aa
> >>
> >> It states
> >>  * which problem it solves
> >>  * and what it does exactly
> >>
> >> And I could not care less about an additional line at the bottom
> stating
> >> "Funded by John Wayne"
> >
> > Almost.  It should have "Fixes #8166" in it to automatically link to
> the issue
> > and close it - Bugfix #8166 doesn't create that link.
> >
>
> Good hints. If it's not already in CODING, we could add these
> guidelines in that file.
>
> Also, since most of you don't seem to be annoyed by the "funded by"
> sentences, I  think we can agree on Victor's proposal: if the new
> feature/bug fix etc. was funded by an organization, a company or an
> individual, a single line (80 chars max) sentence can be added as the
> last line of the commit, after a blank line.
>
> That line should be added only in the last "merge" (final) commit and
> not on all and every individual commit.
>
>  
>
> I disagree. "Funded by" attribution lines should go wherever the
> author feels is appropriate, regardless of whether the commit is a
> merge type, pulling in a whole branch, or the commits are simply
> rebased on top of master.
>
>  
>
> It is a matter of public record:
>
> * QGIS is a public project
>
> * The funding is for a public project.
>
> * The funding is a matter of public record (unless otherwise deemed by
> sponsor).
>
> * The commit log is a public record (and the longest standing one for
> the project).
>
> I fail to see how any of that can be misconstrued as "spam," if the
> line in a commit is merely an attribution, i.e. not part of the first
> line of the commit.
>
> Even if *every* single commit message in the QGIS repo had a "Funded
> by" attribution line, I could not see how that is anything but a
> matter of fact. Actually, I think that would be an awesome record of
> the project's prowess of finding sponsorship.
>
> Regards,
>
> Larry Shaffer
> Dakota Cartography
> Black Hills, South Dakota
>
>  
>
>
>     --
>     Alessandro Pasotti
>     w3:   www.itopen.it <http://www.itopen.it>
>
>     _______________________________________________
>     Qgis-developer mailing list
>     Qgis-developer at lists.osgeo.org <mailto:Qgis-developer at lists.osgeo.org>
>     http://lists.osgeo.org/mailman/listinfo/qgis-developer
>
>  
>
>  
>
> This message has been scanned for viruses by MailControl
> <http://www.mailcontrol.com/>, a service from BlackSpider Technology
>
> Click here
> <https://www.mailcontrol.com/sr/I0txt8yKWP%21GX2PQPOmvUihCLhWP7Wj9hp54mmEOLsPcfq%213p+2gK8O0TJTgqoXxCOZlUrWwm5Ieq4Nrivo6iw==>
> to report this email as spam.
>
>  
>
>
> ------------------------------------------------------------------------
>
> *HR Wallingford and its subsidiaries* uses faxes and emails for
> confidential and legally privileged business communications. They do
> not of themselves create legal commitments. Disclosure to parties
> other than addressees requires our specific consent. We are not liable
> for unauthorised disclosures nor reliance upon them.
> If you have received this message in error please advise us
> immediately and destroy all copies of it.
>
> HR Wallingford Limited
> Howbery Park, Wallingford, Oxfordshire, OX10 8BA, United Kingdom
> Registered in England No. 02562099
>
> ------------------------------------------------------------------------
>
>
> _______________________________________________
> Qgis-developer mailing list
> Qgis-developer at lists.osgeo.org
> http://lists.osgeo.org/mailman/listinfo/qgis-developer