[Qgis-developer] Failing tests
Nathan Woodrow
madmanwoo at gmail.com
Tue Jun 2 04:15:31 PDT 2015
I'm all for strict unit test policy however they need to be able to run on
all platforms consistently in order to enforce that correctly. Taking the
failing PyQgsAppStartup test on Travis, i just ran it on my Linux setup and
it passes fine, yet fails on Travis. I'm skeptical of that test anyway but
it does make it hard to fix when it can't be reproduced..
Compare to Traivs I get these two tests failing:
The following tests FAILED:
100 - PyQgsLocalServer (Failed)
134 - PyQgsPalLabelingServer (Failed)
On Tue, 2 Jun 2015 at 19:31 Matthias Kuhn <matthias at opengis.ch> wrote:
> Hi Jürgen
>
> On 06/02/2015 09:03 AM, Jürgen E. Fischer wrote:
> > Hi Nyall,
> >
> > On Tue, 02. Jun 2015 at 13:34:56 +1000, Nyall Dawson wrote:
> >> I'd be in favour of a hardline "no breaks allowed" approached. You break
> >> travis, your commit gets reverted.
> > -1
> >
> > A general rule doesn't make sense to me - it depends on the break.
> > If you break travis, you should fix it.
>
> For the record, can you elaborate which types of breaks should not be
> fixed and/or why certain breaks should be fixed in master instead of in
> a separate branch/pull request?
>
> Regards
> Matthias
> _______________________________________________
> Qgis-developer mailing list
> Qgis-developer at lists.osgeo.org
> http://lists.osgeo.org/mailman/listinfo/qgis-developer
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osgeo.org/pipermail/qgis-developer/attachments/20150602/6273dfed/attachment.html>
More information about the Qgis-developer
mailing list