[Qgis-developer] Failing tests
Jürgen E. Fischer
jef at norbit.de
Tue Jun 2 08:06:05 PDT 2015
Hi Matthias,
On Tue, 02. Jun 2015 at 11:31:47 +0200, Matthias Kuhn wrote:
> > On Tue, 02. Jun 2015 at 13:34:56 +1000, Nyall Dawson wrote:
> >> I'd be in favour of a hardline "no breaks allowed" approached. You break
> >> travis, your commit gets reverted.
> > -1
>
> > A general rule doesn't make sense to me - it depends on the break.
> > If you break travis, you should fix it.
> For the record, can you elaborate which types of breaks should not be
> fixed and/or why certain breaks should be fixed in master instead of in
> a separate branch/pull request?
Huh? I didn't say breaks shouldn't be fixed. I said just the opposite. But I
said the fix should not not generally be a simple revert.
Jürgen
--
Jürgen E. Fischer norBIT GmbH Tel. +49-4931-918175-31
Dipl.-Inf. (FH) Rheinstraße 13 Fax. +49-4931-918175-50
Software Engineer D-26506 Norden http://www.norbit.de
QGIS release manager (PSC) Germany IRC: jef on FreeNode
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 827 bytes
Desc: Digital signature
URL: <http://lists.osgeo.org/pipermail/qgis-developer/attachments/20150602/561f7a43/attachment.pgp>
More information about the Qgis-developer
mailing list