[Qgis-developer] Adding branch protection to github?

Larry Shaffer larrys at dakotacarto.com
Wed Oct 14 04:31:54 PDT 2015


Hi,

Seems like all protections (against force push, deleting and failing tests)
are a good fit.

There may be instances where some tests are failing on Mac, due to an
oddity with that platform and not with the actual code per se, i.e. the
test needs updated for Mac or some Mac-specific bit needs added to source.
In light of such cases, it might be best to not require that all tests pass
for the Merge button to be enabled, or it may force some devs to wait until
Mac-specific issues are addressed first.

If we if strictly enforce all tests pass, maybe there is a way to tell
Travis that a failure on one of the test platforms is non-critical (Mac),
but a failure on another (Linux) is. ??

Regards,

Larry Shaffer
Dakota Cartography
Black Hills, South Dakota

On Tue, Oct 13, 2015 at 4:41 PM, Nathan Woodrow <madmanwoo at gmail.com> wrote:

> +1 not allowing force push is a good thing IMO
>
> On Wed, Oct 14, 2015 at 8:39 AM, Nyall Dawson <nyall.dawson at gmail.com>
> wrote:
>
>> This seems like a really good idea -
>> https://github.com/blog/2051-protected-branches-and-required-status-checks
>>
>> I noticed it's now been rolled out, and think we should enable this on
>> the QGIS repo ASAP. I can't see any downsides to enabling this and
>> lots of upsides. Can someone with rights do this?
>>
>> Nyall
>> _______________________________________________
>> Qgis-developer mailing list
>> Qgis-developer at lists.osgeo.org
>> http://lists.osgeo.org/mailman/listinfo/qgis-developer
>
>
>
> _______________________________________________
> Qgis-developer mailing list
> Qgis-developer at lists.osgeo.org
> http://lists.osgeo.org/mailman/listinfo/qgis-developer
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osgeo.org/pipermail/qgis-developer/attachments/20151014/20e456af/attachment.html>


More information about the Qgis-developer mailing list