[Qgis-developer] Why QDialogProgress used in QgsVectorLayer::countSymbolFeatures ?

[René-Luc Dhont]

Hi,

I've opened an issue http://hub.qgis.org/issues/14272
And proposed code https://github.com/qgis/QGIS/pull/2780

Thanks for review.
René-Luc

Le 10/02/2016 00:32, Nyall Dawson a écrit :
>
>
> On 10 Feb 2016 7:57 AM, "Nathan Woodrow" <madmanwoo at gmail.com 
> <mailto:madmanwoo at gmail.com>> wrote:
> >
> > Hi,
> >
> > No it would not be the correct place. No gui stuff like that should 
> live in core.
> >
> > Consider it a bug for 2.14 and should be fixed
>
> Haven't we also talked about moving this to the data provider, so that 
> we can take advantage of calculating the count using compiled 
> expressions, etc? That'd be another (good) alternative to this method.
>
> Nyall
>
> >
> > - Nathan
> >
> >
> > On Wed, 10 Feb 2016 1:43 am René-Luc Dhont <rldhont at gmail.com 
> <mailto:rldhont at gmail.com>> wrote:
> >>
> >> Hi Dev,
> >>
> >> A new QGIS Server feature : showFeatureCount, uses the method
> >> QgsVectorLayer::countSymbolFeatures to display feature count in legend.
> >> But this feature doesn't work if a fake X server is not used.
> >>
> >> I discovered that the method QgsVectorLayer::countSymbolFeatures
> >> initialized a QDialogProgress. I wondered if this was the right 
> place to
> >> initialize a dialog ?
> >>
> >> Regards,
> >> René-Luc D'Hont
> >> _______________________________________________
> >> Qgis-developer mailing list
> >> Qgis-developer at lists.osgeo.org <mailto:Qgis-developer at lists.osgeo.org>
> >> List info: http://lists.osgeo.org/mailman/listinfo/qgis-developer
> >> Unsubscribe: http://lists.osgeo.org/mailman/listinfo/qgis-developer
> >
> >
> > _______________________________________________
> > Qgis-developer mailing list
> > Qgis-developer at lists.osgeo.org <mailto:Qgis-developer at lists.osgeo.org>
> > List info: http://lists.osgeo.org/mailman/listinfo/qgis-developer
> > Unsubscribe: http://lists.osgeo.org/mailman/listinfo/qgis-developer
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osgeo.org/pipermail/qgis-developer/attachments/20160210/750d18bb/attachment.html>