[QGIS-Developer] Pre-commit error: astyle not found

[Jürgen E. Fischer]

Hi Harrissou

On Thu, 13. Jul 2017 at 12:53:41 +0200, DelazJ wrote:
> Anyway, I "worked around" by commenting the astyle check part in the
> prepare-commit.sh file, recreate the pre-commit file and I can commit without
> error. I know this disables the check but it wasn't necessary for the changes
> I did (i actually wanted to set the same configuration for the repo than on
> my xenial).

prepare-commit.sh also requires a shell.  

TOPLEVEL=$(git rev-parse --show-toplevel)

probably doesn't produce the right directory, hence 

PATH=$TOPLEVEL/scripts:$PATH

doesn't add the scripts directory to the paths and therefore astyle.sh is not
found.

> But if anything I can do to have this work without resorting to build
> process....

Using it from cygwin works just fine (which IMHO is the bare minimum to get a
usable environment on Windows ;)).


Jürgen

-- 
Jürgen E. Fischer           norBIT GmbH             Tel. +49-4931-918175-31
Dipl.-Inf. (FH)             Rheinstraße 13          Fax. +49-4931-918175-50
Software Engineer           D-26506 Norden             http://www.norbit.de
QGIS release manager (PSC)  Germany                    IRC: jef on FreeNode
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 827 bytes
Desc: not available
URL: <http://lists.osgeo.org/pipermail/qgis-developer/attachments/20170714/0292af03/attachment.sig>