[QGIS-Developer] Gentle reminder: PRs opened this week aren't gauranteed inclusion in 3.12

Nyall Dawson nyall.dawson at gmail.com
Sun Jan 12 15:55:42 PST 2020


Hi all,

I've heard rumours of some large PRs which are planned to be opened this
week, so I thought I'd send a gentle reminder to all to avoid any
misunderstandings:

if you open a PR this week, even though IF it's opened before freeze, it
does NOT guarantee that it will be included in 3.12

There's a limited number of volunteers available for PR reviewing and PR
reviewing (even for seemingly trivial or minor changes) can take many hours
for a single PR. I know that personally I've a very busy week ahead, and
will have limited time available to dedicate to this task*. If you open a
10000 line PR this week, there's absolutely no guarantee that these
volunteer core committer reviewers will have any chance to review your work
and get it merged before freeze.

(* The same applies for already opened PRs -- just having a PR opened in
any state of readiness does not mean it's automatically eligible for
inclusion in 3.12).

If you've critical work which MUST land in 3.12, open your PRs ASAP, make
sure they are in shape ASAP (no failing tests, new unit tests in place),
and provide as much assistance to the volunteer review team as possible.
And if it's life-or-death HAS to be in 3.12, consider approaching a core
reviewer and offering to sponsor their time for reviewing your work.

Nyall

(* I hope it goes without saying, but volunteer PR reviewers being busy
doesn't give **anyone's** work a short-cut into the master codebase without
proper reviews, regardless of who submits the work, their history with the
project, or the organisation behind the work! )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osgeo.org/pipermail/qgis-developer/attachments/20200113/f2635d1e/attachment.html>


More information about the QGIS-Developer mailing list