[QGIS-Developer] QGIS logger plugin in core

Mon Mar 23 00:54:29 PDT 2020

Hi,

I'm ok with pulling it (or a slim version) into c++..

What is the main reason to pull it into QGIS? Because it started of as a
hack using some events from QgsNetworkManager. Nyall then added a lot
more events so more information could be retrieved.
But the plugin itself is actually nothing more then 'catching' those
events and showing them. Most stuff is gui  stuff.

So: what would be the actual benefit (except that everybody will have
it... mmm, also people never working with web-based data....)?

Also note that this started of as a slim/simple tool, just logging the
url's to the QMessageLog, see this version and screenshot:

https://github.com/rduivenvoorde/qgisnetworklogger/tree/V0.1.0

I agree with Nyall that current implementation has some limitations,
mainly because of the nice treeview and the lookups that occur to fill
all the details that fill the tree.

Indeed I spend A LOT of time to make this tree not crash anymore
(especially when you delete a part of it, or when you try to filter it).
But having it as a plugin which you can remove/disable is in this way a
good thing I would say.

One thing to note (IF somebody is funding this): it would be great to
have some communication between gdal and it's requests and QGIS too
(Nyall talked about this earlier with Even). Some requests are not
handled by QGIS anymore, but done by GDAL. So these are currently being
missed.

Regards,

Richard Duivenvoorde

On 3/23/20 12:44 AM, Tim Sutton wrote:
> Hi Nyall
> 
> Great to hear you are now more open to having this kind of logging in
> QGIS. Our budget and budgeted time for adding logging is pretty small
> (in the order to 1-2 days work). I suspect Richard has sunk quite a
> considerable amount of time into making his plugin so beautiful and
> functional. I think there is a good use case for building something more
> simple in core - a checkbox in settings to enable logging web requests,
> and a simple text output in the QgsLogMessage of each URL as it is
> called, along with the return code for the request. In my little
> universe, Richard's plugin would then still exist as the ‘Ferrari
> version, whilst out of the box our users have some basic tooling for
> debugging their services that are not playing nice. 
> 
> Regards
> 
> Tim
> 
>> On 22 Mar 2020, at 22:42, Nyall Dawson <nyall.dawson at gmail.com
>> <mailto:nyall.dawson at gmail.com>> wrote:
>>
>> On Mon, 23 Mar 2020 at 01:53, Tim Sutton <tim at kartoza.com
>> <mailto:tim at kartoza.com>> wrote:
>>>
>>> Hi All
>>>
>>> A while ago we had a discussion here on the mailing list about adding
>>> Network logging to QGIS, similar to what you can do in your
>>> browser[1]. Nyall at the time (maybe others) was concerned about
>>> security implications of including a network logging tool in QGIS. We
>>> were wondering what specific security impacts could be expected (as
>>> opposed to for example installing Richard’s very nice logger
>>> plugin)[2]? In other words, is there really a good rationale not to
>>> port this to C++ and integrate into QGIS core? I think it is very
>>> broadly useful for anyone working with remote layers and trying to
>>> figure out why they are not loading...
>>
>> I'm a tentative +1 now. My original security concerns were dismissed
>> because... well.. we can't really stop this information leaking anyway
>> (cos Qt), so a malicious plugin will always be able to capture the
>> requests. In fact, having it in c++ will potentially lower the risk,
>> cos there's less need for 3rd party plugins to cover this use case
>> (that said: Richard maintains the existing Network Logger plugin, so
>> that one can be implicitly trusted -- this concern would only extend
>> to other future network logger style plugins from other sources!).
>>
>> Also, it's **extremely** useful.
>>
>> Now, some thoughts:
>> - it would **definitely** need to be ported to c++. The plugin has an
>> issue where it slows down after logging and displaying many requests
>> in the tree. Both Richard and I spent considerable time trying to
>> avoid this, with minimal results. A c++ version should give us more
>> flexibility to address the performance issue. (and note: this IS a
>> serious issue, as it can cause the whole QGIS UI to slow, not just the
>> network logger dock)
>> - some nice icons are definitely required :)
>>
>> Nyall
>>
>>>
>>> Regards
>>>
>>> Tim
>>>
>>>
>>>
>>> [1]
>>> http://osgeo-org.1560.x6.nabble.com/QGIS-Developer-URL-Request-logging-of-QGIS-tp5382271p5382330.html
>>> [2] https://plugins.qgis.org/plugins/qgisnetworklogger/
>>>
>>> —
>>>
>>>
>>>
>>>
>>>
>>>
>>>
>>>
>>> Tim Sutton
>>>
>>> Co-founder: Kartoza
>>> Ex Project chair: QGIS.org <http://QGIS.org>
>>>
>>> Visit http://kartoza.com to find out about open source:
>>>
>>> Desktop GIS programming services
>>> Geospatial web development
>>> GIS Training
>>> Consulting Services
>>>
>>> Skype: timlinux
>>> IRC: timlinux on #qgis at freenode.net <http://freenode.net>
>>>
>>> I'd love to connect. Here's my calendar link to make finding time easy.
>>>
>>> _______________________________________________
>>> QGIS-Developer mailing list
>>> QGIS-Developer at lists.osgeo.org <mailto:QGIS-Developer at lists.osgeo.org>
>>> List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer
>>> Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer
> 
> —
> 
> 
> 
> 
> 
> 
> 
> 
> *Tim Sutton*
> 
> *Co-founder:* Kartoza
> *Ex Project chair:* QGIS.org <http://QGIS.org>
> 
> Visit http://kartoza.com <http://kartoza.com/> to find out about open
> source:
> 
> Desktop GIS programming services
> Geospatial web development
> GIS Training
> Consulting Services
> 
> *Skype*: timlinux 
> *IRC:* timlinux on #qgis at freenode.net <http://freenode.net>
> 
> I'd love to connect. Here's my calendar link
> <https://calendly.com/timlinux> to make finding time easy.
> 
> 
> _______________________________________________
> QGIS-Developer mailing list
> QGIS-Developer at lists.osgeo.org
> List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer
> Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer
> 