[QGIS-Developer] 3.16.16 build failure (NetBSD 9, pkgsrc)

[Greg Troxel]

I'm trying to do an update of pkgsrc from 3.16.15 to 3.16.16, and got a
build failure in test code.  (It seems building tests is on by default
which is perfectly ok, and I should try to run them.)  Immediately prior
to building 3.16.16, I built 3.16.15 which was clean all the way to a
binary package.  I did the build of 3.16.16 without qgis installed at
all, in case that old headers were leaking into the new build.  (All
previous micro updates have been without issue, except perhaps adding a
file or two to the manifest.)

It sort of looks like there is a test for an optional feature that isn't
guarded; I'm not building with qtwebkit.   I would hope it isn't really
necessary to have that, as it is truly enormous and takes hours  to
build.  I've been running without it for a few years and haven't noticed
anything missing.

I will look into this more but I thought I'd see if anyone else has seen
a similar failure.

  [ 96%] Built target qgis_externalresourcewidgetwrapper_autogen
  Consolidate compiler generated dependencies of target qgis_externalresourcewidgetwrapper
  [ 96%] Building CXX object tests/src/gui/CMakeFiles/qgis_externalresourcewidgetwrapper.dir/testqgsexternalresourcewidgetwrapper.cpp.o
  /tmp/work/geography/qgis/work/qgis-3.16.16/tests/src/gui/testqgsexternalresourcewidgetwrapper.cpp: In member function 'void TestQgsExternalResourceWidgetWrapper::testBlankAfterValue()':
  /tmp/work/geography/qgis/work/qgis-3.16.16/tests/src/gui/testqgsexternalresourcewidgetwrapper.cpp:141:27: error: 'class QgsExternalResourceWidget' has no member named 'mWebView'
     connect( ww.mQgsWidget->mWebView, &QWebView::loadFinished, &loop, &QEventLoop::quit );
                             ^~~~~~~~
  /tmp/work/geography/qgis/work/qgis-3.16.16/tests/src/gui/testqgsexternalresourcewidgetwrapper.cpp:141:48: error: incomplete type 'QWebView' used in nested name specifier
     connect( ww.mQgsWidget->mWebView, &QWebView::loadFinished, &loop, &QEventLoop::quit );
                                                  ^~~~~~~~~~~~
  In file included from /usr/pkg/qt5/include/QtTest/qtest.h:45:0,
                   from /usr/pkg/qt5/include/QtTest/QtTest:11,
                   from /tmp/work/geography/qgis/work/qgis-3.16.16/src/test/qgstest.h:19,
                   from /tmp/work/geography/qgis/work/qgis-3.16.16/tests/src/gui/testqgsexternalresourcewidgetwrapper.cpp:18:
  /tmp/work/geography/qgis/work/qgis-3.16.16/tests/src/gui/testqgsexternalresourcewidgetwrapper.cpp:145:27: error: 'class QgsExternalResourceWidget' has no member named 'mWebView'
     QVERIFY( ww.mQgsWidget->mWebView->isVisible() );
                             ^
  /tmp/work/geography/qgis/work/qgis-3.16.16/tests/src/gui/testqgsexternalresourcewidgetwrapper.cpp:151:27: error: 'class QgsExternalResourceWidget' has no member named 'mWebView'
     QVERIFY( ww.mQgsWidget->mWebView->isVisible() );
                             ^
  /tmp/work/geography/qgis/work/qgis-3.16.16/tests/src/gui/testqgsexternalresourcewidgetwrapper.cpp:152:28: error: 'class QgsExternalResourceWidget' has no member named 'mWebView'
     QCOMPARE( ww.mQgsWidget->mWebView->url().toString(), QStringLiteral( "about:blank" ) );
                              ^
  At global scope:
  cc1plus: warning: unrecognized command line option '-Wno-redundant-move'
  gmake[2]: *** [tests/src/gui/CMakeFiles/qgis_externalresourcewidgetwrapper.dir/build.make:90: tests/src/gui/CMakeFiles/qgis_externalresourcewidgetwrapper.dir/testqgsexternalresourcewidgetwrapper.cpp.o] Error 1
  gmake[1]: *** [CMakeFiles/Makefile2:19308: tests/src/gui/CMakeFiles/qgis_externalresourcewidgetwrapper.dir/all] Error 2
  gmake: *** [Makefile:166: all] Error 2
  *** Error code 2



Sort of related, I could not tell from tests/README.md if the tests all
run with the not-yet-installed qgis, or if it's like gdal where it tests
the installed version.  I'm guessing not-yet-installed.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 194 bytes
Desc: not available
URL: <http://lists.osgeo.org/pipermail/qgis-developer/attachments/20220118/59138075/attachment.sig>