[QGIS-Developer] Rights to merge Pull Request even if CI is red
Vincent Picavet
vincent.ml at oslandia.com
Fri Jun 26 02:12:36 PDT 2026
Hi,
On 26/06/2026 08:28, Nyall Dawson via QGIS-Developer wrote:
>
>
> On Fri, 26 Jun 2026 at 16:18, Tim Sutton <tim at kartoza.com> wrote:
>
> Hi
>
>
>
> Ill add it to the next PSC agenda - we can get flamed there instead :-P
>
>
> Thanks Tim, it's much appreciated.
Glad to see this topic raised !
>
> My personal preference would be something like:
>
> - we decouple "core committer" status from git rights. "core committer" is just a recognition of skills alone. initially it comes with git rights, but can outlast those.
> - git rights expire automatically after a period of inactivity (say 6 months)
Big +1, also in terms of cybersecurity it would be a good decision.
> - developers who have previously had git rights but lost them due to inactivity must go through some re-endorsement process to demonstrate that they are up-to-date with current development policies and the current state of the codebase
Having some new contributions accepted should be enough to retrieve commit rights, as it implies being up-to-date with the codebase and policies.
Also, we need a public place where we have a list of current core committers and commit rights owner. Better if that is automatically updated.
Vincent
>
> Happy to join in on a psc meeting to discuss if needed!
>
> Nyall
>
>
>
> Regards
>
> Tim
>
> On Thu, Jun 25, 2026 at 10:19 PM Nyall Dawson via QGIS-Developer <qgis-developer at lists.osgeo.org> wrote:
>
>
>
> On Thu, 25 Jun 2026 at 21:39, Even Rouault <even.rouault at spatialys.com> wrote:
> >
> > Hi Nyall,
> >
> > your answer doesn't really answer my question :-) Is the restriction for every committer or a subset?
> >
> > Who has rights for changing qgis/qgis github settings? (not necessarily asking for them to be extended, but just so we know). It would be good to communicate when some settings that might affect workflows are adjusted
>
> We're definitely overdue for an overhaul on our github rights. Our current policy is LAUGHABLY ridiculous (basically "you get merge rights once, you've got them for life... even if you go off to work for ESRI or disappear off the face of the earth" 🤣).
>
> It's not a discussion I feel like leading though. I tried once, and just got flamed for even bringing it up.
>
> Nyall
>
>
>
>
>
> >
> > I'd say that we should probably give up for now to auto-merge if it blocks approved pull requests from being merged
> >
> > Even
> >
> > Le 25/06/2026 à 13:30, Nyall Dawson a écrit :
> >
> >
> >
> > On Thu, 25 June 2026, 9:24 pm Even Rouault via QGIS-Developer, <qgis-developer at lists.osgeo.org> wrote:
> >>
> >> Hi Julien,
> >>
> >> I just tried looking at your PR [0] and I also don't seem to have the
> >> right to force merge it (only "auto-merge" rights that depend on green CI)
> >>
> >> It would be indeed great to have some clarification of who might have
> >> such rights or not, so we can see if there isn't a bottleneck that must
> >> be resolved. I'm not sure why we would want such rights to be restricted
> >> to a subset of people with "regular" merge rights rather than the whole
> >> group.
> >
> >
> > An alternative would be to remove the merge rules which require tests to pass -- that'd avoid expanding rights while still allowing the blockage to be removed.
> >
> > (Downside is that doing this breaks the ability to "auto merge")
> >
> > Nyall
> >>
> >>
> >> Even
> >>
> >> Le 25/06/2026 à 12:24, Julien Cabieces via QGIS-Developer a écrit :
> >> > Hi devs,
> >> >
> >> > I cannot merge PR #66483 [0] because there is at least one unrelated
> >> > test failure every time the CI is launched (I restarted it 7 times), although the PR was approved
> >> > 6 days ago.
> >> >
> >> > I have already tackled the issue of the test_gui_fileuploader [1] which was
> >> > failing very often recently because of badssl.com <http://badssl.com> being unstable but there
> >> > are now other issues.
> >> >
> >> > A few months ago, I had the rights to merge a PR even if tests were
> >> > failing, but I don't have them anymore and I cannot contribute anymore
> >> > on #66483 related issues (I have more fix commits based on this PR).
> >> >
> >> > It seems to me that other code committers still have these rights as I see
> >> > PRs with a red CI still being merged.
> >> >
> >> > May I have these rights too so I can continue to contribute normally?
> >> >
> >> > Shall every core committer have these rights ?
> >> >
> >> > Kind regards,
> >> > Julien
> >> >
> >> > [0] https://github.com/qgis/QGIS/pull/66483
> >> > [1] https://github.com/qgis/QGIS/pull/66543
> >> >
> >> --
> >> http://www.spatialys.com
> >> My software is free, but my time generally not.
> >> LLMs contribute to global warming and brain rot
> >>
> >> _______________________________________________
> >> QGIS-Developer mailing list
> >> QGIS-Developer at lists.osgeo.org
> >> List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer
> >> Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer
> >
> > --
> > http://www.spatialys.com
> > My software is free, but my time generally not.
> > LLMs contribute to global warming and brain rot
> _______________________________________________
> QGIS-Developer mailing list
> QGIS-Developer at lists.osgeo.org
> List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer
> Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer
>
>
>
> --
>
> Tim Sutton
> *Kartoza Cofounder
> *Tim is a member of the QGIS Project Steering Committee*
> *
> *
> *
> *T *: +27(0) 87 809 2702 *E *:**tim at kartoza.com *W* : kartoza.com <http://kartoza.com/>
>
> /
> /
> /
> /
> /This email and any attachments are confidential and intended solely for the use of the individual or entity to whom they are addressed. If you /
> /have received this email in error, please notify the sender immediately and delete it from your system. Unauthorised use, disclosure, or copying/
> /of the contents is prohibited./
>
>
> _______________________________________________
> QGIS-Developer mailing list
> QGIS-Developer at lists.osgeo.org
> List info:https://lists.osgeo.org/mailman/listinfo/qgis-developer
> Unsubscribe:https://lists.osgeo.org/mailman/listinfo/qgis-developer
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osgeo.org/pipermail/qgis-developer/attachments/20260626/c2b83fe2/attachment.htm>
More information about the QGIS-Developer
mailing list