[Qgis-psc] Attachment widget broken in the attribute table

Wed Aug 7 03:17:50 PDT 2019

On 07.08.19 08:00, Matthias Kuhn wrote:
>
> Hi Tim,
>
> On 8/6/19 11:45 PM, Tim Sutton wrote:
>> Hi Matthias
>>
>> Thanks for this - we did discuss this at the PSC meeting. Can’t this
>> simply be handled by having a changelog for bug fix releases when we
>> get the magic feed to changelog thing done? Then we can simply mark
>> what was fixed and what was regressed and why. A job for Anita H who
>> is maintaining the changelog for us.
>
> There is already a category of "notable fixes" in the changelog. We
> could add a "changelog" label (next to the "feature" label) to
> automate listing of notable fixes in the changelog.
>
> For the regressions I would propose to handle them manually (i.e. no
> magic feed) to have a good selection and wording - it's always harder
> to communicate things that got worse than things that got better.
>
I also think so, foremost as usually "notable fixes" outweigh regressions.
>
>>
>> I think the issue is more about communication than having black and
>> white rules - there is always going to be some exception that we need
>> to figure out how to deal with. ‘Can’t fix’ is a valid issue
>> resolution even if it is a regression.
>
> Fair point. Please note that in this case it wasn't marked as
> resolved, but left open since the current patch is only a bandaid.
>
>> We also chatted about KDAB and were mostly in favour of that - at
>> least it would be good to have a complete list of upstream issues
>> that affect QGIS that we know of and then approach them for some
>> indication of cost to repair.
>
> Cool!
>
> There is a list in
> https://github.com/qgis/QGIS/pull/30930#issuecomment-518660334 which
> can be used for that.
>
do you mean https://github.com/qgis/QGIS/pull/30930#issuecomment-515371162 ?

Cheers

Marco

> Regards
>
> Matthias
>
>
>>
>> Regards
>>
>> Tim
>>
>>> On 6 Aug 2019, at 16:02, Matthias Kuhn <matthias at opengis.ch
>>> <mailto:matthias at opengis.ch>> wrote:
>>>
>>> Hi PSC,
>>>
>>> As discussed with Giovanni Manghi in [1],  I'd like to bring an
>>> issue with the attachment widget to your attention.
>>>
>>> Since QGIS 3.0 there has been an issue with the attachment widget,
>>> that when clicking the [...] browse button in the attribute table,
>>> QGIS has crashed. This has been reported in [2] about 1.5 years ago.
>>>
>>> In the last months, at least 3 core developers have spent a total of
>>> at least 10 hours trying to recover the original browse
>>> functionality. Unfortunately without success.
>>>
>>> Finally, a pull request was created to remove the button from the
>>> attribute table [1] and has been merged into master (backports for
>>> 3.4 and 3.8 are pending).
>>>
>>> There was a broad agreement that at the current point we are not
>>> able to fix it in a reasonable timeframe, so it's better to remove
>>> the button (which had one sole functionality of crashing QGIS). All
>>> other functionality of the attachment widget (outside the attribute
>>> table) is unaffected.
>>>
>>>
>>> One of the conclusions in [1] was, that it would be good to
>>> collaborate with Qt (e.g. KDAB) for bugfixing. Apart from this
>>> particular issue, there are a few others for which an upstream fix
>>> is the only (or the cleanest) solution. It would be good if we could
>>> agree on a budget for this (e.g. 5 days of time) and get in touch
>>> with upstream to get the ball rolling. It would be nice if the PSC
>>> could take a decision and do the preparation work for that (if
>>> possible pre 3.10).
>>>
>>> On another note, it would be good to clarify on our stance regarding
>>> priority handling. In the discussion there was a pretty tight notion
>>> of a "no regressions allowed, whatever the cost" policy. This binary
>>> way this argument was used made it quite hard to decide on the best
>>> way forward for the application. I have the plan to try to avoid
>>> regressions wherever possible and to make QGIS more stable at the
>>> same time. But if the project decision is that stability shouldn't
>>> be much of a focus before anything tagged a "regression" is
>>> eliminated I will have to check my priorities again.
>>>
>>> Thanks a lot
>>>
>>> Matthias
>>>
>>> [1] https://github.com/qgis/QGIS/pull/30930#issuecomment-518660334
>>>
>>> [2] https://github.com/qgis/QGIS/issues/26948
>>>
>>> _______________________________________________
>>> Qgis-psc mailing list
>>> Qgis-psc at lists.osgeo.org <mailto:Qgis-psc at lists.osgeo.org>
>>> https://lists.osgeo.org/mailman/listinfo/qgis-psc
>>
>> —
>>
>>
>>
>>
>>
>>
>>
>>
>> *Tim Sutton*
>>
>> *Co-founder:* Kartoza
>> *Ex Project chair:* QGIS.org <http://QGIS.org>
>>
>> Visit http://kartoza.com <http://kartoza.com/> to find out about open
>> source:
>>
>> Desktop GIS programming services
>> Geospatial web development
>> GIS Training
>> Consulting Services
>>
>> *Skype*: timlinux 
>> *IRC:* timlinux on #qgis at freenode.net <http://freenode.net>
>>
>> I'd love to connect. Here's my calendar link
>> <https://calendly.com/timlinux> to make finding time easy.
>>
>
> _______________________________________________
> Qgis-psc mailing list
> Qgis-psc at lists.osgeo.org
> https://lists.osgeo.org/mailman/listinfo/qgis-psc

-- 
Marco Bernasocchi

QGIS.org Co-chair
http://berna.io

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osgeo.org/pipermail/qgis-psc/attachments/20190807/665d0887/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: KartozaNewLogoThumbnail.jpg
Type: image/jpeg
Size: 6122 bytes
Desc: not available
URL: <http://lists.osgeo.org/pipermail/qgis-psc/attachments/20190807/665d0887/attachment.jpg>