[Qgis-psc] [QGIS-Developer] Direct push forbidden to master

Nathan Woodrow madmanwoo at gmail.com
Fri Nov 8 04:23:47 PST 2019


I agree with Even.  The issue here is the slow CI builds and lack of
Windows CI builds.
To make this process smoother and more solid for everyone we need to invest
in better CI not pretend we can just ignore it for the sake of getting a
commit in..

- Nathan

On Fri, Nov 8, 2019 at 10:05 PM Even Rouault <even.rouault at spatialys.com>
wrote:

> On vendredi 8 novembre 2019 19:32:06 CET Nyall Dawson wrote:
> > On Fri, 8 Nov 2019 at 18:33, ElPaso <elpaso at itopen.it> wrote:
> > > I'm with Jürgen on this, I think we all are responsible developers
> > > acting for the good of QGIS and I didn't see any abuse on direct
> commits
> > > in the past few years.
> > >
> > >
> > > On the contrary, I think I should have committed to master directly to
> > > correct a PR of mines that I merged by mistake the day before 3.10
> > > release (https://github.com/qgis/QGIS/pull/32369) instead of waiting
> for
> > > an approval that didn't arrive in time (in this case it wasn't really a
> > > big problem though).
> >
> > I don't think Denis is arguing for forced-reviews of pull requests.
> > Rather just that all changes GO through pull requests so that we can
> > be sure they don't break CI.
>
> What is obvious here is that a CI for Windows would avoid avoided this
> case,
> as the cost of maintaining the Windows build alive mostly relies on a
> single
> person currently.
> As it seems that most QGIS users run Windows, it might be worth for the
> project to invest into that, both in funding the time of the folks who
> would
> set up that and possibly paying for a beefy enough server (potentially
> from a
> commercial CI hosting solution) that would sustain the load of pull
> requests.
>
> And paying for Travis extra build could potentially save time for a number
> of
> contributors. For the github OSGeo organization, mostly used by PROJ &
> GDAL,
> it is between 4000-5000 USD/year for 11 parallel builds (this includes a
> discount for OSGeo being a non-profit). There might be cheeper
> alternatives by
> other competitors.
>
> --
> Spatialys - Geospatial professional services
> http://www.spatialys.com
> _______________________________________________
> Qgis-psc mailing list
> Qgis-psc at lists.osgeo.org
> https://lists.osgeo.org/mailman/listinfo/qgis-psc
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osgeo.org/pipermail/qgis-psc/attachments/20191108/0a961fd7/attachment.html>


More information about the Qgis-psc mailing list