[QGIS-trac] [Quantum GIS] #1213: Attribute Table editing / Stop Editing dialog behavior is confusing

[Quantum GIS]

#1213: Attribute Table editing / Stop Editing dialog behavior is confusing
------------------------------------------------+---------------------------
   Reporter:  smizuno                           |              Owner:  nobody       
       Type:  bug                               |             Status:  new          
   Priority:  major: does not work as expected  |          Milestone:  Version 1.0.0
  Component:  Data Provider                     |            Version:  HEAD         
   Keywords:  attribute edit                    |   Platform_version:               
   Platform:  All                               |           Must_fix:  No           
Status_info:  0                                 |  
------------------------------------------------+---------------------------
 1. After opening Attribute Table, if you toggle editing on and then toggle
 it off without making any changes the Stop Editing dialog appears. If you
 choose Save or Discard, then subsequent toggling editing on/off without
 changes does not show the Stop Editing dialog. If Cancel is chosen then
 the Stop Editing dialog dialog appears again when toggling editing on/off
 and no changes.

 2. in the Stop Editing dialog, if Cancel is chosen then editing is still
 active, but the Edit button shows off. The Edit button needs to toggled
 twice to get the Stop Editing dialog now.

 3. if editing and changes are pending, attempting to close the Attribute
 Table closes the window without provoking the Stop Editing dialog. Most
 users would expect to be asked to save changes. The also would expect to
 return to editing if Cancel is chosen.

 Expected behavior:

 + when editing is active but there are no changes, then the Stop Editing
 dialog should NOT be presented on stop editing or Attribute Table is
 closed.

 + when editing is active and there are changes, then the Stop Editing
 dialog should  be presented on stop editing or Attribute Table is closed.

 + Cancel in the Stop Editing dialog should return to editing.

 + the Toggle Editing button should reflect the current editing state.

 as of r9010

-- 
Ticket URL: <https://trac.osgeo.org/qgis/ticket/1213>
Quantum GIS <http://qgis.org>
Quantum GIS is an Open Source GIS viewer/editor supporting OGR, PostGIS, and GRASS formats