[QGIS-trac] Re: [Quantum GIS] #767: Only one KML vector layer loaded

Quantum GIS qgis at qgis.org
Mon Jan 26 13:23:41 EST 2009


#767: Only one KML vector layer loaded
----------------------------------------------------+-----------------------
        Reporter:  didge                            |         Owner:  mhugent      
            Type:  enhancement                      |        Status:  new          
        Priority:  minor: annoyance or enhancement  |     Milestone:  Version 2.0.0
       Component:  OGR Layer support                |       Version:  HEAD         
      Resolution:                                   |      Keywords:  kml ogr s57  
Platform_version:                                   |      Platform:  Debian       
        Must_fix:  No                               |   Status_info:  0            
----------------------------------------------------+-----------------------
Changes (by wonder):

 * cc: falahdab (added)

Comment:

 Florian,

 I've tried your plugin and it seems to work with one test layer I have.

 While it does its job, I have some suggestions:

  * I really think that this should be implemented directly in qgis
 application, not as a plugin. It's not very intuitive for users. I
 recommend you to do it in QgisApp::addVectorLayers() function. The logic
 can be simple - if the layer has only one sublayer, keep it as is. If
 there are more sublayers, let the user choose which ones he would like to
 load.
  * use tree view (or widget) instead of table. Tree view with multiple
 columns and without decorated root items look much better than a table -
 despite the name, it's not necessary to use it just for trees :)
  * it would be better to support selects with shift and ctrl
  * it would be good to include also sublayer type (point/line/polygon) if
 possible
  * the patch you've posted is missing CMakeLists.txt and ogrsublayers.png
 in plugin's directory. People usually don't like patches that fail to
 compile :)

 Martin

-- 
Ticket URL: <https://trac.osgeo.org/qgis/ticket/767#comment:6>
Quantum GIS <http://qgis.org>
Quantum GIS is an Open Source GIS viewer/editor supporting OGR, PostGIS, and GRASS formats


More information about the QGIS-trac mailing list