[Qgis-user] QGIS 2.10.1 adding PostGIS Views

[Sandro Santilli]

On Tue, Sep 01, 2015 at 02:37:22PM +0200, Jürgen E. Fischer wrote:
> Hi Sandro,
> 
> On Tue, 01. Sep 2015 at 13:48:33 +0200, Sandro Santilli wrote:
> > I agree with Luca this should have been better not backported to 2.8.3.
> > Only proper bugs should be backported, and this was a (debatable)
> > GUI enhancement, as far as I can tell.
> 
> We intend to only backport fixes and not bugs. ;)
> 
> You were always supposed to select the key column - preselecting the first
> column was the bug (also debatable).  And #11317 is a ticket that demonstrates
> there were unaware users.

Reading #11317 I looks to me that the reported bug was about
"Add PostGIS Layer" not giving the user full detail of why a
layer could not be loaded: "is an invalid layer - not loaded".
In this I agree with Aren here: http://hub.qgis.org/issues/11317#note-6

> That the first column often happens to be the primary key and and the combobox
> is not lexically sorted is somewhat pure luck - and unless you avoid having the
> key verified (using "use estimated metadata"), keeping a wrongly select
> column will make the layer to insert invalid.

I agree that the reported regression was based on the false expectation
that QGIS would pick a primary key automatically, but in the
(unlikely?) case a user was aware of that and properly coded the view
to ensure primary key was first (or only) numeric the change was
indeed a degradation of the experience.

> But I agree that the tooltip that you get on disabled lines (not only for the
> key selection, but also geometry type and srid) might not be visible enough
> (but that IMHO would be just a GUI enhancement).

There should maybe be another rule about LTS backports being:
debatable fixes/enhancement need to be debated more on list ?

--strk;