[Qgis-user] Button order on Add Data dialogues

[Alessandro Pasotti]

Hi,

in QGIS 3 the source select dialogs have been deeply refactored and they
now use a base class for a better consistency among different providers.
Buttons [Close, Add] should be the same in all dialogs, some specific
providers may add other buttons.

There has been a lot of discussion about the buttons: initial
implementation had [Add, Ok, Close] where Add=Apply, Ok=Apply+Close and
Close=Cancel (it was just closing the dialog).

Now we agreed on dropping the 'Ok' and leave [Close, Add, Help].

Now about the order, that should be controlled by Qt and it should be
platform-dependent following the O.S. guidelines: see
http://doc.qt.io/qt-5/qdialogbuttonbox.html and, for windows,
https://msdn.microsoft.com/en-us/library/windows/desktop/bb246415(v=vs.85).aspx

That said, there is probably room for improvement by moving the [Close,
Add] buttons from the class to the UI file so that the Qt ordering is
honored (I suspect that by adding those buttons in the class instead of in
the UI it is not).

So, yes, please file a ticket and assign it to me so I don't forget to look
at that.



On Tue, Dec 19, 2017 at 5:59 PM, McDonaldR <McDonaldR at angus.gov.uk> wrote:

> Hi List,
>
>
>
> I’m running QGIS 2.18.12 and latest 2.99 on Windows 7.  I have a question
> about the order of the buttons in the dialogue boxes on the Manage Layers
> toolbar.  Maybe it’s my OCD and maybe others have a similar issue…
>
>
>
>
>
>
>
> ·         The Add Spatialite dialogue has Add | (Set Filter) | (Update
> Statistics) | Close | Help
>
>
>
> ·         The Add WCS dialogue has Close | Add | Help
>
>
>
> ·         The Add WMS dialogue has Add | Close | Help **
>
>
>
> ·         The Add Database Layer dialogue has Add | Set Filter | Close |
> Help
>
>
>
> To me the order of Add | Close | Help makes sense and the order of the
> buttons on the WCS dialogue** is a minor bug.
>
>
>
> In the latest master 2.99 the buttons on the Add Data dialogue boxes have
> all been switched to be *Close* | *Add* | *Help* with the *Add* button
> disabled until a layer has been selected. Now I don’t know if it is just me
> but I am used to using buttons that have the “positive” action of *Add*
> or *OK* first and then the “negative” action of *Close* or * Cancel* next
> (to the right) and then *Help* (if required).
>
>
>
>
>
> Maybe I just need to be retrained to click the next button to the right
> but at the moment it just feels wrong as I keep clicking Close instead of
> Add.  Anyone else?  Is it a feature request to have the button order
> changed or a minor bug?
>
>
>
> Thanks
>
>
>
> Ross
>
>
>
> *Ross McDonald | *GIS Data Coordinator | Angus Council, People, IT |
> Angus House, Orchardbank Business Park, Sylvie Way, Forfar DD8 1AT* | t:
> 01307 476419*
>
>
>
>
> This message is strictly confidential. If you have received this in error,
> please inform the sender and remove it from your system. If received in
> error you may not copy, print, forward or use it or any attachment in any
> way. This message is not capable of creating a legal contract or a binding
> representation and does not represent the views of Angus Council. Emails
> may be monitored for security and network management reasons. Messages
> containing inappropriate content may be intercepted. Angus Council does not
> accept any liability for any harm that may be caused to the recipient
> system or data on it by this message or any attachment.
>
> _______________________________________________
> Qgis-user mailing list
> Qgis-user at lists.osgeo.org
> List info: https://lists.osgeo.org/mailman/listinfo/qgis-user
> Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-user
>



-- 
Alessandro Pasotti
w3:   www.itopen.it
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osgeo.org/pipermail/qgis-user/attachments/20171220/add22b4a/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: image001.png
Type: image/png
Size: 7357 bytes
Desc: not available
URL: <http://lists.osgeo.org/pipermail/qgis-user/attachments/20171220/add22b4a/attachment.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: image002.png
Type: image/png
Size: 3424 bytes
Desc: not available
URL: <http://lists.osgeo.org/pipermail/qgis-user/attachments/20171220/add22b4a/attachment-0001.png>