[SeasonOfDocs] Probot DCO

[Felicity Brand]

Well I'm stuck in some sort of awful loop. No idea what to do next.

   1. I forked the repo.
   2. Downloaded the repo locally.
   3. I created a branch.
   4. I made a small change to the ReadMe.
   5. I committed and pushed back to GitHub.
   6. I raise a PR.
   7. I can see the checks and action required.

[image: image.png]
7. I followed the instructions. Got this - no idea if any action is
required or not.
[image: image.png]
8. Did this - suspect I typed my password incorrectly but no way to be sure.
[image: image.png]
9. Now I got this.
[image: image.png]
How do I update my PR so that it now recognizes my sign-off? I tried to
amend my commit but I guess it hasn't worked. Stumped.

I guess you only need to set this up once and then for all future commits
it will automatically add my signature. Is that true?

Sorry for all the screenshots - wonder if this email will make it through
or go to the holding yard.

Cheers
Felicity

On Fri, Aug 16, 2019 at 8:13 PM Jo Cook <jo.k.cook at gmail.com> wrote:

> Hi Erin et al,
>
> I've just submitted a pull request to test this, initially without any
> signature, and it worked a treat. I like the way it explains exactly what
> you need to do to fix the problem, and that once you make the changes at
> the command line, the tests pass, so no more faffing in the web interface.
> My only observation is that we probably do need to expand on the text to
> indicate why it's asking for the sign off. I'd also like to see this
> combined with pull request templates, which I think would give us the full
> solution.
>
> Thanks for setting it up! I'd be more than happy for it do be permanent
> but maybe we should wait for a few other people to test first.
>
> Jo
>
> On Tue, Aug 13, 2019 at 10:17 PM Erin McKean <emckean at google.com> wrote:
>
>> Hi folks!
>>
>> I've installed the Probot DCO (https://github.com/probot/dco) on the
>> templates repository.
>>
>> If people could send test pull requests both with and without the
>> signature requirement that would be great!
>>
>> Also, please confirm that we're all okay with the wording of the DCO
>> included in the bot. If we are, someone should move that we make this test
>> permanent. :)
>>
>> Thanks!
>>
>> Erin
>>
>> --
>> Erin McKean | Developer Relations Program Manager, Open Source Strategy |
>>  emckean at google.com | she/her
>>
>> _______________________________________________
>> SeasonOfDocs mailing list
>> SeasonOfDocs at lists.osgeo.org
>> https://lists.osgeo.org/mailman/listinfo/seasonofdocs
>>
>
>
> --
> ------------------------
> http://about.me/jocook
> _______________________________________________
> SeasonOfDocs mailing list
> SeasonOfDocs at lists.osgeo.org
> https://lists.osgeo.org/mailman/listinfo/seasonofdocs
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osgeo.org/pipermail/seasonofdocs/attachments/20190817/9ccd221d/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: image.png
Type: image/png
Size: 42652 bytes
Desc: not available
URL: <http://lists.osgeo.org/pipermail/seasonofdocs/attachments/20190817/9ccd221d/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: image.png
Type: image/png
Size: 50865 bytes
Desc: not available
URL: <http://lists.osgeo.org/pipermail/seasonofdocs/attachments/20190817/9ccd221d/attachment-0005.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: image.png
Type: image/png
Size: 63337 bytes
Desc: not available
URL: <http://lists.osgeo.org/pipermail/seasonofdocs/attachments/20190817/9ccd221d/attachment-0006.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: image.png
Type: image/png
Size: 32218 bytes
Desc: not available
URL: <http://lists.osgeo.org/pipermail/seasonofdocs/attachments/20190817/9ccd221d/attachment-0007.png>