[Tilecache] Watermarking Tiles in TileCache

[Christopher Schmidt]

On Thu, May 03, 2007 at 03:05:23PM +0930, Andrew Hughes wrote:
> Hey All,
> 
> Watermaking Patch is now available:
> 
>    * Trac Ticket #8
>          o http://dev.tilecache.org/ticket/8
>    * SVN Patch (Based on trunk)
>          o 
>          http://dev.tilecache.org/attachment/ticket/8/ticket_8_watermarking_patch_FINAL.txt
> 
> The only difference between the patches is that the FINAL also has an 
> update for the README.

Just as a minor review thing: in the future, you should always update
your SVN before making patches. (Usually this is 'update' in a dropdown,
or 'svn up' at the command line.) The patch you provided reverts
existing changes to the ImageLayer code that were likely added after you
initially checked out.

Other than that, this looks good. Nice work stumbling thruogh the config
parsing to find everything you needed :) I'm willing to apply this to
trunk and kick out a 1.8, but:

"If you haven't contributed before, fill out an ICLA[1] or CCLA[2] regarding
the work." -- http://dev.tilecache.org/

If you can get me one of those (to labs at metacarta.com), I'll go ahead
and drop the patch in.

[1] http://tilecache.org/icla.txt
[2] http://tilecache.org/ccla.txt

Regards,
-- 
Christopher Schmidt
MetaCarta