[GRASS-dev] xganim: fix compilation or remove completely?

[Vaclav Petras]

Hi,

when testing the previous problems with C++11/clang/Mavericks, I used the
following compilation settings on Ubuntu 12.04:

  export CC=clang
  export CXX=clang++
  export CFLAGS="-ggdb -Wall -Wextra -Werror-implicit-function-declaration
-Wmissing-prototypes -Wmissing-declarations -Wredundant-decls"
  export CXXFLAGS="-ggdb -std=c++11"

I get the following errors in `visualization/xganim` directory:

./bitmaps/rewind.xbm:4:28: error: constant expression evaluates to 128
which cannot be narrowed to type 'char'
   0x00, 0x00, 0x00, 0x30, 0x80, 0x01, 0x28, 0x40, 0x01, 0x30, 0xa0, 0x01,
                           ^~~~
./bitmaps/rewind.xbm:4:28: note: override this message by inserting an
explicit cast
   0x00, 0x00, 0x00, 0x30, 0x80, 0x01, 0x28, 0x40, 0x01, 0x30, 0xa0, 0x01,
                           ^~~~
                           stat)c_cast<char>(

and a lot of other similar errors.

I'm not getting these errors on Mavericks.

I'm not able to test the xganim tool [1] right now; there is no
ready-to-use example and I'm not sure which environment it requires (I'm
getting white window bigger than my screen). However, the question is: It
is worth keeping the xganim tool in code or should we remove it completely?

Are there any functions which xganim tool does have comparing to
g.gui.animation [2]? Or are there some other advantages of xganim? We
should avoid loosing functionality as it was with tools such as gm_animate
[3]. So these questions shall be answered before removing xganim.

Best,
Vaclav

[1] http://grass.osgeo.org/grass70/manuals/xganim.html
[2] http://grass.osgeo.org/grass70/manuals/g.gui.animation.html
[3] http://grass.osgeo.org/grass64/manuals/gm_animate.html
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osgeo.org/pipermail/grass-dev/attachments/20131211/e85ac81b/attachment.html>