[GRASS-QA] GRASS QA: paul | ./grass6/lib/gis/datum.c |1 clones ( datum.c )| 0 monsters | 0 warnings

grass-qa at proxy.soccerlab.polymtl.ca grass-qa at proxy.soccerlab.polymtl.ca
Fri Nov 3 15:24:57 EST 2006



Hello paul,

here a report on your recent GRASS-CVS change:

ANALYSIS

your changes to files/functions:


lib/gis/datum.c functions


G_get_datum_by_name (Begins at: 46 Ends at: 57)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       2 |       |      OK |
LOC:          |      12 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

G_datum_name (Begins at: 60 Ends at: 68)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       1 |       |      OK |
LOC:          |       9 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

G_datum_description (Begins at: 71 Ends at: 79)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       1 |       |      OK |
LOC:          |       9 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

G_datum_ellipsoid (Begins at: 82 Ends at: 111)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       1 |       |      OK |
LOC:          |      30 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

G_get_datumparams_from_projinfo (Begins at: 113 Ends at: 152)
--------------+---------+-------+---------+
Complexity:   |       6 |       |      OK |
ParamNBR:     |       3 |       |      OK |
CalledNBR:    |      19 |       |      OK |
LOC:          |      40 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

read_datum_table (Begins at: 155 Ends at: 208)
--------------+---------+-------+---------+
Complexity:   |       6 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |      15 |       |      OK |
LOC:          |      54 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

compare_table_names (Begins at: 211 Ends at: 217)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       1 |       |      OK |
LOC:          |       7 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

Clone analysis:

This file has 1 potentially cloned functions:
  compare_table_names

In lib/gis/datum.c clones of  compare_table_names are:
	raster/r.colors/main.c  cmp_names


__________________________________________

Threshold GRASS6 key metrics values at 2006-11-03 are:
---------------------------+-----------+---------+
                    median | upper     | outlier |
                           | quartile  | limit   |
---------------------------+-----------+---------+
Complexity (Cyclo):      5 |        25 |      37 |
ParamNBR:                2 |         6 |       8 |
CalledNBR:              10 |        60 |      85 |
LOC:                    41 |       189 |     265 |
---------------------------+-----------+---------+

Measures (see below Web page for details):
 Complexity (Cyclo): a complexity index
 ParamNBR: number of passed parameters
 CalledNBR: number of called functions
 LOC: Lines Of Code

Message interpretation:
 OK : Nothing to say at all
 *  : above 75 % of value warning
 ** : this is getting close to be out of range, consider revising the code
 ***: this is a monster, definitely you should revise this function


__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html




More information about the grass-qa mailing list