[pdal] Inconsistency between docs and functionality in las.writer

[Andrew Bell]

On Mon, Dec 21, 2015 at 3:51 AM, Kristian Evers <kreve at gst.dk> wrote:

> I have noticed a slight inconsistency between the docs and the
> functionality of las.writer and now wondering which one is wrong.
>
>
>
> On http://www.pdal.io/stages/writers.las.html it says that the default
> value of the option minor_version is 3, but in reality when you do a ‘pdal
> translate’ without specifying any options you get a las/laz file with
> format version 1.2. The source code confirms this in line 69 of
> io\las\LasWriter.cpp:
>
>
>
> m_minorVersion.setDefault(2);
>
>
>
> It’s a minor detail, just wondering if the docs or the code needs to be
> changed. Was it the intention to write las-files with minor_version=3? I’ll
> do a pull request with a fix once I know if the docs or the code is
> correct. Personally I think that the default minor_version should be 3, as
> it says in the docs.
>

I've fixed the documentation to reflect the code (should show up online
shortly).  The default has in reality been version 2 for a long time, so
I'm leaving it alone for now, but if there's enough demand, it can
certainly be changed.

Thanks for catching this!

-- 
Andrew Bell
andrew.bell.ia at gmail.com
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osgeo.org/pipermail/pdal/attachments/20151221/8896cde7/attachment.html>