[Gdal-dev] [Patch] Problem with gdal_translate with the parameter -a_ullr 0 0 x x

[Mateusz Loskot]

Jean-Claude Repetto wrote:
> Frank Warmerdam a écrit :
>> Mateusz Loskot wrote:
>>> Jean-Claude Repetto wrote:
>>>> Jean-Claude Repetto wrote :
>>>>> The ECW file is correct. I have checked it by reading it directly with
>>>>> the ECW library.
>>>>> The bug occurs when GDAL reads the file. I have looked at the source
>>>>> code (version 1.4.2), and it seems the bug is in the file
>>>>> ecwdataset.cpp .
>>>> This is a patch that I propose :
>>>>
>>>> --- frmts/ecw/ecwdataset.cpp.orig       2007-10-24
>>>> 11:35:44.000000000 +0200
>>>> +++ frmts/ecw/ecwdataset.cpp    2007-10-24 11:41:59.000000000 +0200
>>>> @@ -1539,9 +1539,9 @@
>>>>
>>>>      if( psFileInfo->fOriginX != 0.0
>>>>          || psFileInfo->fOriginY != 0.0
>>>> -        && (psFileInfo->fCellIncrementX != 0.0 &&
>>>> +        || (psFileInfo->fCellIncrementX != 0.0 &&
>>>>              psFileInfo->fCellIncrementX != 1.0)
>>>> -        && (psFileInfo->fCellIncrementY != 0.0 &&
>>>> +        || (psFileInfo->fCellIncrementY != 0.0 &&
>>>>              psFileInfo->fCellIncrementY != 1.0) )
>>>>      {
>>>>          bGeoTransformValid = TRUE;
>>>>
>>>>
>>>> With this patch applied to GDAL 1.4.2, both gdalinfo and qgis give
>>>> correct results.
>>>
>>> Jean-Claude,
>>>
>>> Please, submit this patch as a ticket. We will test it. Thanks!
>>
>> Jean-Claude / Mateusz,
>>
>> This patch looks reasonable to me, and once the ticket is filed should
>> likely be applied in 1.4 as well as trunk.
>>
>> Best regards,
>>
> 
> Hi,
> 
> I have filled a ticket for this bug (#1935), but it seems that the patch
> has not been applied to 1.4.3 . Does it need more investigation ?

Jean-Claude,

It does not need more investigation and Frank approved the patch above,
but as I see, the ticket was not assigned to milestone 1.4.3
and that's why it hasn't been applied to the 1.4.3.

I always follow roadmap [1] of current milestone.
Frank assigns tickets to a milestone.

[1] http://trac.osgeo.org/gdal/roadmap

Cheers
-- 
Mateusz Loskot
http://mateusz.loskot.net