[gdal-dev] [Qgis-developer] GDAL 2.2.0 beta 2 available

[Even Rouault]

On lundi 24 avril 2017 22:21:28 CEST Matthias Kuhn wrote:
> Hi Even,
> 
> In the end, isn't solution 2) the same as solution 1) for the user? 

Somehow, except that I'd wish official GDAL no longer export shapelib symbols to avoid the 
issue of #6860

> In
> which case it sounds like it mainly puts additional load on
> distributions for no added value. Am I missing something?

For distributions that would ship both GDAL 2.2 and QGIS 2.18, yes that's an (hopefully small) 
burden to apply the revert patch of
https://trac.osgeo.org/gdal/changeset/37997

> 
> Especially because "some other workflows" is a quite loose definition.

The details are in
https://trac.osgeo.org/gdal/ticket/6860

> 
> In the end it sounds like the proper solutions would be to fix dxf2shp -
> but since that has already been sent to the graveyard it's questionable
> if someone wants to do the effort.

Agreed that investing time in modifying dxf2shp isn't really something appealing.

> 
> More options
> 
> 4) ship shapelib with qgis itself (as part of the dxf2shp plugin)

Well, it is more or less partly shipped in dxf2shp except than the .c files aren't compiled, and 
there are at least the one doing the I/O interface missing.

> 
> 5) require GDAL < 2.2 for building QGIS 2.18

Not really an option for distributions that track latest versions of their components


Hum, there might be an intermediate option: revert the change in GDAL 2.2 branch, and keep 
it in 2.3dev which will probably be released in one year, at a time where QGIS 3 should have 
been released to.


> 
> Matthias
> 
> On 4/24/17 7:20 PM, Even Rouault wrote:
> > Hi,
> > 
> > > - Shape: do not export Shapelib symbols for builds
> > > 
> > > --with-hide-internal-symbols (#6860)
> > 
> > It turns out that the above change breaks QGIS 2.18 build, in
> > particular the DXF2SHP converter native plugin, since it does a nasty
> > trick: the QGIS build tree has the shapelib 2.10 includes files, but
> > relies on linking against shapelib symbols exported by libgdal. The
> > plugin apparently no longer exists in QGIS master, which builds fine
> > against GDAL 2.2beta2.
> > 
> > 
> > 
> > So I'm not sure what to do:
> > 
> > 1) revert #6860 and export again shapelib symbols from GDAL. But this
> > apparently breaks some other workflows
> > 
> > 2) let distributions apply a patch to do this revert, while they use
> > QGIS 2.18 or other code that depend on GDAL exporting shapelib symbols
> > 
> > 3) Change DXF2SHP plugin to use OGR API instead of shapelib, but I'm
> > not feeling like I would do that myself.
> > 
> > 
> > 
> > My opinion would be to favor 2)
> > 
> > 
> > 
> > Opinions ?
> > 
> > 
> > 
> > Even
> > 
> > 
> > 
> > 
> > Spatialys - Geospatial professional services
> > 
> > http://www.spatialys.com
> > 
> > 
> > 
> > _______________________________________________
> > Qgis-developer mailing list
> > Qgis-developer at lists.osgeo.org
> > List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer
> > Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer


-- 
Spatialys - Geospatial professional services
http://www.spatialys.com
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osgeo.org/pipermail/gdal-dev/attachments/20170424/ca73f036/attachment.html>