[GeoNode-devel] Commit code in GeoNode master branch
pjdufour.dev at gmail.com
Tue Sep 19 06:15:34 PDT 2017
Awesome! +1 to enable by default. We can add in some settings,
enumerations, etc. to give additional abstraction if necessary at a later
stage. This is a significant step forward for GeoNode UX. Thank you
On Sep 19, 2017 8:23 AM, "Francesco Bartoli" <xbartolone at gmail.com> wrote:
> Great contribution Dimitri! +1 in the code base
> Sent from Nylas Mail
> the best free email app for work
> On set 19 2017, at 1:04 pm, Simone Dalmasso <simone.dalmasso at gmail.com>
>> Hi Dimitris,
>> I would definitely see this contribution as part of the core codebase
>> rather that having it as contrib optional app. Therefore I'm +1 in keeping
>> the js into layer_detail.html, while for css you could add it to the
>> base.less (that then you can compile minified into base.css).
>> If you have tests, the better but being mostly js, as I suppose, it's ok
>> without them as well as we don't have testing facilities in place for js.
>> While for the doc, it is in a dedicated folder into the main repo
>> you can find the most convenient place in there.
>> Thanks a lot for this, very nice and welcome feature.
>> Let us know if you need further info.
>> 2017-09-19 10:33 GMT+02:00 Dimitris Karakostis <
>> karakostis.dimitris at gmail.com>:
>> Hi all,
>> I have integrated the Layer Filtering functionality in my local master
>> branch of GeoNode. The functionality gives the possibility to build basic
>> queries based on the layer's attributes and values and download part of the
>> layers (in the provided formats) (see screenshot). Currently it works for
>> local, vector layers.
>> In the past we have discussed this functionality here:
>> As this is my first contribution to the GeoNode community, I want to be
>> sure that the commit complies to best practices in terms of documentation,
>> potential tests and code.
>> layer_detail.html. Should I move these snippets of code in external files?
>> How and where do I update the documentation?
>> Any advice on the above would be greatly appreciated.
>> geonode-devel mailing list
>> geonode-devel at lists.osgeo.org
>> geonode-devel mailing listgeonode-devel at lists.osgeo.orghttps://lists.osgeo.org/mailman/listinfo/geonode-devel
> geonode-devel mailing list
> geonode-devel at lists.osgeo.org
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the geonode-devel