[GeoNode-devel] Commit code in GeoNode master branch

[Angelos Tzotsos]

Thanks Dimitris!
+1 to include as default

Angelos

On 09/19/2017 04:15 PM, Patrick Dufour wrote:
> Awesome!  +1 to enable by default.  We can add in some settings,
> enumerations, etc. to give additional abstraction if necessary at a later
> stage.  This is a significant step forward for GeoNode UX.  Thank you
> Dimitris!
>
> Patrick
>
> On Sep 19, 2017 8:23 AM, "Francesco Bartoli" <xbartolone at gmail.com> wrote:
>
>> Great contribution Dimitri! +1 in the code base
>>
>> Sent from Nylas Mail
>> <https://n1.nylas.com/link/72e0e9e7634d6c6f2a502dc7068f5361d905ee3269feda10a8072c3c9d4d1f86/0?redirect=https%3A%2F%2Fnylas.com%3Fref%3Dn1&recipient=geonode-devel%40lists.osgeo.org>,
>> the best free email app for work
>>
>> On set 19 2017, at 1:04 pm, Simone Dalmasso <simone.dalmasso at gmail.com>
>> wrote:
>>
>>> Hi Dimitris,
>>>
>>> I would definitely see this contribution as part of the core codebase
>>> rather that having it as contrib optional app. Therefore I'm +1 in keeping
>>> the js into layer_detail.html, while for css you could add it to the
>>> base.less (that then you can compile minified into base.css).
>>>
>>> If you have tests, the better but being mostly js, as I suppose, it's ok
>>> without them as well as we don't have testing facilities in place for js.
>>>
>>> While for the doc, it is in a dedicated folder into the main repo
>>> https://github.com/GeoNode/geonode/tree/master/docs
>>> <https://github.com/GeoNode/geonode/tree/master/docs?recipient=geonode-devel%40lists.osgeo.org>,
>>> you can find the most convenient place in there.
>>>
>>> Thanks a lot for this, very nice and welcome feature.
>>>
>>> Let us know if you need further info.
>>>
>>> Ciao
>>>
>>> 2017-09-19 10:33 GMT+02:00 Dimitris Karakostis <
>>> karakostis.dimitris at gmail.com>:
>>>
>>> Hi all,
>>>
>>> I have integrated the Layer Filtering functionality in my local master
>>> branch of GeoNode. The functionality gives the possibility to build basic
>>> queries based on the layer's attributes and values and download part of the
>>> layers (in the provided formats) (see screenshot). Currently it works for
>>> local, vector layers.
>>>
>>> In the past we have discussed this functionality here:
>>> https://goo.gl/7rTDzF
>>> <https://goo.gl/7rTDzF?recipient=geonode-devel%40lists.osgeo.org>
>>>
>>> As this is my first contribution to the GeoNode community, I want to be
>>> sure that the commit complies to best practices in terms of documentation,
>>> potential tests and code.
>>>
>>> Currently I have included CSS and javascript code in the
>>> layer_detail.html. Should I move these snippets of code in external files?
>>>
>>> How and where do I update the documentation?
>>>
>>> Any advice on the above would be greatly appreciated.
>>>
>>> Thanks.
>>> Dimitris
>>>
>>> _______________________________________________
>>> geonode-devel mailing list
>>> geonode-devel at lists.osgeo.org
>>> https://lists.osgeo.org/mailman/listinfo/geonode-devel
>>> <https://lists.osgeo.org/mailman/listinfo/geonode-devel?recipient=geonode-devel%40lists.osgeo.org>
>>>
>>>
>>>
>>>
>>> --
>>> Simone
>>>
>>> _______________________________________________
>>> geonode-devel mailing listgeonode-devel at lists.osgeo.orghttps://lists.osgeo.org/mailman/listinfo/geonode-devel
>>>
>>>
>> _______________________________________________
>> geonode-devel mailing list
>> geonode-devel at lists.osgeo.org
>> https://lists.osgeo.org/mailman/listinfo/geonode-devel
>>
>>
>
>
> _______________________________________________
> geonode-devel mailing list
> geonode-devel at lists.osgeo.org
> https://lists.osgeo.org/mailman/listinfo/geonode-devel


-- 
Angelos Tzotsos, PhD
Charter Member
Open Source Geospatial Foundation
http://users.ntua.gr/tzotsos

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osgeo.org/pipermail/geonode-devel/attachments/20170920/c93f1cd8/attachment.html>