[geos-devel] Weekly Report 5 - Adding Voronoi Diagram to GEOS

[vishal tiwari]

Hey,

In order to submit a subset, should i make different branches in the git
repository and send a pull request for each of them separately? Or there is
some other way?

Thanks,
Vishal


On 23 July 2013 14:05, vishal tiwari <hi.vishal123 at gmail.com> wrote:

> I tried to send a pull request for Triangle class, but seems like every
> commit has been sent for the review(new to git), sorry for that. I ll send
> it as subsets and i ll clean it as u mentioned before.
>
> Thanks,
> Vishal
>
>
> On 23 July 2013 11:38, Sandro Santilli <strk at keybit.net> wrote:
>
>> Vishal, I think the biggest issue so far has been making peer reviewing
>> easy.
>> One way to improve that would be to cleanup a subset of what you've been
>> modifying and submit it for inclusion upstream. The subset should be small
>> enough to be easy to read and complete with testcases. I'm thinking it
>> could be changes to the Triangle class with its tests, and next one
>> could maybe be changes to the CoordinateList class, with relative tests.
>>
>> Cleaning that up means removing all changes that are not directly
>> related to the focus of the work. For example making sure that you
>> don't have style changes for a change that's addressing adding new
>> functionality. The diff must be _easy_ to read as that gives your
>> code better opportunities to be commented on.
>>
>> Looking forward for your pull request as soon as possible, I'd like
>> to have the time to merge it in before evaluation time.
>>
>> Thank you for the care you'll put into this :)
>>
>> --strk;
>>
>> On Sat, Jul 20, 2013 at 01:45:54AM +0530, vishal tiwari wrote:
>> > Hey,
>> >
>> > My week 5 report is as follows:
>> >
>> > *1. Work Done:*
>> >
>> >    - This week was spent mainly, in fixing the memory leaks and
>> >    segmentation faults. I have tested all the methods and classes that
>> have
>> >    been ported. Everything seems to be working fine. Thus completion of
>> the
>> >    Voronoi port via C++ interface.
>> >
>> > *2. Problems Faced:*
>> >
>> >    - No problems other than memory leaks and seg faults.
>> >
>> > *3. Work to be done in the next week:*
>> >
>> >    - Check for bugs because of the coming evaluation.
>> >    - I will look into, how the C-api of geos has been implemented.
>> >
>> >
>> > wiki link: http://trac.osgeo.org/geos/wiki/GSoC
>> > Repository link : https://github.com/vishaltiwari/libgeos
>> >
>> > Thanks and kind regards,
>> >
>> > --
>> > Vishal Tiwari
>> > Undergraduate
>> > Computer Science and Engineering
>> > Lab for Spatial Informatics
>> > IIIT-Hyderabad
>> _______________________________________________
>> geos-devel mailing list
>> geos-devel at lists.osgeo.org
>> http://lists.osgeo.org/mailman/listinfo/geos-devel
>>
>
>
>
> --
> Vishal Tiwari
> Undergraduate
> Computer Science and Engineering
> Lab for Spatial Informatics
> IIIT-Hyderabad
>



-- 
Vishal Tiwari
Undergraduate
Computer Science and Engineering
Lab for Spatial Informatics
IIIT-Hyderabad
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osgeo.org/pipermail/geos-devel/attachments/20130723/60a0356a/attachment-0001.html>