[geos-devel] Splitting _r and non _r functions in 2 different .h ?

Sandro Santilli strk at keybit.net
Wed Jun 18 09:52:58 PDT 2014


On Wed, Jun 18, 2014 at 06:32:25PM +0200, Even Rouault wrote:

> I've hit an integration problem with QGIS using the non _r API and spatialite 
> calling (accidently) finishGEOS() when closing a spatialite DB, causing later 
> crashes in QGIS.
> So I've converted all the QGIS calls to GEOS to the _r API, and to do that the 
> easiest solution was to alter geos_c.h to remove the non _r symbols and fix all 
> compilation problems. But to make that robust in the length, it would be good 
> to be upstreamed.
> GDAL and MapServer also now use the _r API for similar reasons. And it would 
> also be good to be sure noone reintroduce calls to the non _r API.

I was actually thinking to deprecate the non _r API at some point,
but I've been too lazy to port PostGIS to the _r ones so far, so
I keep adding the non _r ones even for new signature :/

--strk;


More information about the geos-devel mailing list