[GRASS5] Which colors are right?
neteler at itc.it
Wed Nov 21 04:20:23 EST 2001
On Tue, Nov 20, 2001 at 08:36:49PM -0800, Eric G. Miller wrote:
> On Tue, 20 Nov 2001 19:44:50 -0800
> "Eric G. Miller" <egm2 at jps.net> wrote:
> > So, I was looking at fixing that d.area dig_list problem, when I found
> > the current sources don't compile. Amongst the rubble was the redefinition
> > of all the defined colors in colors.h and vect/dig_defines.h -- and the
> > definitions don't match! How this could be the case for so long and
> > not cause an error, I don't know. But, the GRASS standard color defines
> > should only live in one place. I'm voting to drop the definitions in
> > dig_defines and have it include colors.h. But, I don't yet know the
> > ramifications of doing so...
> As follow-up, I made a few modifications to colors.h and vect/dig_defines.h
> and so far it looks okay. I'm updating my CVS and will do a rebuild followed
> by some other checks. At least v.digit seemed to get color numbers by
> string name, so it seems okay...
Hi Eric, hi all
I also realized that several color definitions are spreaded in GRASS.
Can we reduce it to one only? When v.digit and others work string based
rather than color index based, it should not break anything.
So I propose to keep only src/includes/colors.h
More information about the grass-dev