[GRASS5] Diffs for grass 5.0.2 package for debian woody now available.

[Nephero]

----- Original Message -----
From: "Glynn Clements" <glynn.clements at virgin.net>
To: "giuseppe" <nephero at supereva.it>
Cc: <grass5 at grass.itc.it>; <fog at debian.org>
Sent: Friday, July 11, 2003 7:48 PM
Subject: Re: [GRASS5] Diffs for grass 5.0.2 package for debian woody now
available.


> Looking at the diff, I have a couple of questions:
>
> 1. "configure" has already been run, and lex/yacc source files have be
> processed to produce the intermediate C files. Is this due to Debian
> policy, or is it an artifact of the way that the package was produced?
This was an artifact, Federico already pointed this problem, and tomorrow
I'll see what can be done.
(With a bit of help from Federico himself)
I apologize for this but did't notice at once.
>
> 2. What was the purpose of this patch:
>
> --- grass-5.0.2.orig/src/display/devices/lib/Text2.c
> +++ grass-5.0.2/src/display/devices/lib/Text2.c
> @@ -170,9 +170,11 @@
>   double text_size_x,double text_size_y,double text_rotation,
>   char *string)
>  {
> - double sinrot = sin (D2R (text_rotation)) ;
> - double cosrot = cos (D2R (text_rotation)) ;
> -
> +double sinrot,cosrot;
> + //double sinrot = sin (D2R (text_rotation)) ;
> + //double cosrot = cos (D2R (text_rotation)) ;
> + sinrot = sin (D2R (text_rotation)) ;
> + cosrot = cos (D2R (text_rotation)) ;
>   am_inside = 0 ;
>   curx = basex = (double)x ;
>   cury = basey = (double)y ;
>
> Is this due to a gcc bug?
The png driver didn't compile correctly, (but the package was created and
usable anyway) so I made this little fix and now it seems fine (compiles and
runs fine). I think the catch was the definition/assignment in the same
line. I basically just splitted them in different lines. The gcc I used is
the one bundled with Debian Woody. It doesn't seem to me a gcc bug. Maybe
Federico or someone else can better answer this question than me. Please
remember the patch applies to 5.0.2, Silke already pointed out that it's no
use for the CVS version, that had already fixed this problem indipendently.

> 3. What is the purpose of debian/fixpaths.sh? The entire GRASS
> installation (i.e. everything under $prefix/grass5) is supposed to be
> relocatable. If the installation is moved, the only thing that should
> need to be changed is the definition of GISBASE in the grass5 script.
Again, fixpaths.sh was in the Official Debian package I think (I'll check),
so I've to turn this question to the official developer.
Anyway, I just answered this question quickly because I'll be off for the
weekend. I hope to fix the first problem tomorrow and give you more precise
answers.

> --
> Glynn Clements <glynn.clements at virgin.net>
>
>