[GRASS5] GUI code cleanup patch

Glynn Clements glynn at gclements.plus.com
Mon Mar 13 07:43:28 EST 2006


Cedric Shock wrote:

> > That seems reasonable, except that I would suggest leaving the
> > label/desc entries untouched, and either moving the choice to the
> > point where the value is actually used, or creating a separate entry
> > in opts() and copying the label/desc entry to that instead.
> 
> I agree completely. This patch accomplishes nothing, really, except to 
> separate the changes needed to set up for having a better gui.tcl from the 
> new one when it comes. As such I was trying to keep the list of changes to a 
> minimum. The changes included here are just enough to clean up the calling 
> convention and add the guisection attribute which my plans for gui.tcl hinge 
> on. Anyway, I just copied the program logic straight across between languages 
> to have a nice clear and understandable commit.

Right; I overlooked that this was the existing behaviour in that regard.

I've committed your patch as-is.

-- 
Glynn Clements <glynn at gclements.plus.com>




More information about the grass-dev mailing list