[GRASS-dev] ps.map fprintf -> G_

[Martin Landa]

and the patch ... ;-)

2007/1/7, Martin Landa <landa.martin at gmail.com>:
> Hi,
>
> I have prepared a new version of the patch where verbose mapping
> instruction is removed. It will cause "ERROR: verbose : illegal
> request" when the verbose mapping instruction is used.
>
> Not sure if we can just remove this instruction...
>
> Regards, Martin
>
> 2007/1/4, Martin Landa <landa.martin at gmail.com>:
> > Hi Jachym,
> >
> > 2007/1/3, Jachym Cepicky <jachym.cepicky at centrum.cz>:
> > > Hi,
> > > nice job, thanks for the patch, but when I'm thinking about it, ...
> > >
> > >  this patch makes ps.map set it's verbosity not by the --quiet
> > > or --verbose flags, but also according to the input configuration file.
> >
> > Right, this patch allows to set verbosity level by the --q/v flag or
> > by verbose mapping instruction.
> >
> > > imho, the simplest solution should be, remove the VERBOSE keyword from
> > > ps.map. It would not harm to anythink. I doubt, some people are parsing
> >
> > Not sure, it would break backward compatibility. OK, maybe the verbose
> > instruction should be removed later, now just printing appropriate
> > warning about it. There is also question about priority: the --q/v
> > flag should overwrite the mapping instruction or not?
> >
> > > output from ps.map in their scripts.
> > >
> > > If so, G_set_verbose function is the best solution.
> > >
> > > What do others think?
> >
> > ...
> >
> > > Jachym
> >
> > Thanks for the feedback Jachym.
> >
> > >
> > > On Tue, Dec 26, 2006 at 11:16:44AM +0100, Martin Landa wrote:
> > > > Hi all,
> > > >
> > > > trying to change fprintf to G_message/warning/fatal_error in ps.map
> > > > module I found one complication. There is a special mapping
> > > > instruction --- VERBOSE. I think this instruction should overwrite
> > > > GRASS_VERBOSE environment variable(??). There is also need to have a
> > > > special function G_set_verbose() which allows to set a given verbosity
> > > > level after first calling of G_verbose() fn. Please look at the patch
> > > > (especially at verbose.c.diff). Thanks a lot.
> > > >
> > > > Best regards, Martin
> > > >
> > > > --
> > > > Martin Landa <landa.martin at gmail.com> * http://gama.fsv.cvut.cz/~landa *
> > >
> > >
> > > > _______________________________________________
> > > > grass-dev mailing list
> > > > grass-dev at grass.itc.it
> > > > http://grass.itc.it/mailman/listinfo/grass-dev
> > >
> > > --
> > > Jachym Cepicky
> > > e-mail: jachym.cepicky at centrum.cz
> > > URL: http://les-ejk.cz
> > > GPG: http://www.les-ejk.cz/pgp/jachym_cepicky-gpg.pub
> > > -----------------------------------------
> > > OFFICE:
> > > Department of Geoinformation Technologies
> > > Zemedelska 3
> > > 613 00, Brno
> > > Czech Republick
> > > e-mail: xcepicky at node.mendelu.cz
> > > URL:    http://mapserver.mendelu.cz
> > > Tel.:   +420 545 134 514
> > >
> > >
> > > -----BEGIN PGP SIGNATURE-----
> > > Version: GnuPG v1.4.3 (GNU/Linux)
> > >
> > > iD8DBQFFm97SyKt0uAjU4I8RAh4lAKCMce8cDJEO5Yf8Wra2msvgzAAfDwCfRraX
> > > tGACE41v2F2Yv2UKt6AXuEI=
> > > =2I9W
> > > -----END PGP SIGNATURE-----
> > >
> > >
> > >
> >
> >
> > --
> > Martin Landa <landa.martin at gmail.com> * http://gama.fsv.cvut.cz/~landa *
> >
>
>
> --
> Martin Landa <landa.martin at gmail.com> * http://gama.fsv.cvut.cz/~landa *
>


-- 
Martin Landa <landa.martin at gmail.com> * http://gama.fsv.cvut.cz/~landa *
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ps_map-vq-2.diff.gz
Type: application/x-gzip
Size: 8209 bytes
Desc: not available
Url : http://lists.osgeo.org/pipermail/grass-dev/attachments/20070107/6bf83130/ps_map-vq-2.diff.gz