[GRASS-dev] Patch for 3D hull generation

[Benjamin Ducke]

Hmmm, you mean you would like to have my screenshot
as illustration for the v.hull manpage?
That can be done, but don't you think it is a little
bit too "overloaded" for that purpose?
Maybe we could add it to the GRASS screenshots gallery
instead and use something simpler for the man page?

I also think that license is OK. Only thing that bother
me a bit in hindsight is:

"... in its entirety".

Because the code I included is changed to work with the
GRASS data model and floating point precision plus I have cut
out some parts that make no sense in a GRASS module.
So maybe we should include an unaltered version of
the original source code, as well?

How would you interpret "entirety"?

Cheers,

Benjamin

Markus Neteler wrote:
> Hi Benjamin,
> 
> tested and uploaded. I have added an example but your is
> much nicer. Please consider to patch description.html for
> this (then we could upload also your nice screenshot).
> 
> concerning the chull.c copyright - to me it looks GPL compliant:
> 
> /*
> This code is described in "Computational Geometry in C" (Second Edition),
> Chapter 4.  It is not written to be comprehensible without the
> explanation in that book.
> 
> Input: 3n integer coordinates for the points.
> Output: the 3D convex hull, in postscript with embedded comments
>         showing the vertices and faces.
> 
> Compile: gcc -o chull chull.c
> 
> Written by Joseph O'Rourke, with contributions by
>   Kristy Anderson, John Kutcher, Catherine Schevon, Susan Weller.
> Last modified: March 1998
> Questions to orourke at cs.smith.edu.
> --------------------------------------------------------------------
> This code is Copyright 1998 by Joseph O'Rourke.  It may be freely
> redistributed in its entirety provided that this copyright notice is
> not removed.
> --------------------------------------------------------------------
> */
> 
> So I have uploaded it to SVN.
> 
> Markus
> 
> On Jan 18, 2008 10:10 AM, Benjamin Ducke <benjamin.ducke at ufg.uni-kiel.de> wrote:
>> Dear all,
>>
>> I have attached a patch that extends v.hull to accept 3D vector point
>> maps and create a 3D hull composed of faces and a kernel at the 3D
>> geometric center of the hull.
>>
>> I have attached a small screenshot from ParaView to show what I mean.
>>
>>
>> The patch is against SVN trunk. Apply inside v.hull subdir with -p1.
>>
>> Cheers,
>>
>> Benjamin
>>
>> --
>> Benjamin Ducke, M.A.
>> Archäoinformatik
>> (Archaeoinformation Science)
>> Institut für Ur- und Frühgeschichte
>> (Inst. of Prehistoric and Historic Archaeology)
>> Christian-Albrechts-Universität zu Kiel
>> Johanna-Mestorf-Straße 2-6
>> D 24098 Kiel
>> Germany
>>
>> Tel.: ++49 (0)431 880-3378 / -3379
>> Fax : ++49 (0)431 880-7300
>> www.uni-kiel.de/ufg
>>
> 
> 

-- 
Benjamin Ducke, M.A.
Archäoinformatik
(Archaeoinformation Science)
Institut für Ur- und Frühgeschichte
(Inst. of Prehistoric and Historic Archaeology)
Christian-Albrechts-Universität zu Kiel
Johanna-Mestorf-Straße 2-6
D 24098 Kiel
Germany

Tel.: ++49 (0)431 880-3378 / -3379
Fax : ++49 (0)431 880-7300
www.uni-kiel.de/ufg