[GRASS-dev] Re: [GRASS GIS] #676: r.watershed: different output map
options do not allow for fully qualified map names
GRASS GIS
trac at osgeo.org
Tue Jul 7 06:04:58 EDT 2009
#676: r.watershed: different output map options do not allow for fully qualified
map names
-----------------------+----------------------------------------------------
Reporter: mlennert | Owner: grass-dev at lists.osgeo.org
Type: defect | Status: new
Priority: normal | Milestone: 6.4.0
Component: Raster | Version: 6.4.0 RCs
Resolution: | Keywords: r.watershed
Platform: Linux | Cpu: Unspecified
-----------------------+----------------------------------------------------
Comment (by mlennert):
Replying to [comment:5 mmetz]:
> Replying to [comment:4 mlennert]:
> > Replying to [comment:3 hamish]:
> > > Replying to [comment:2 mlennert]:
> > > > Ok, but then the wxGUI should not automatically add @mapset
> > > > when you chose an existing file for output. So, maybe this
> > > > should be reclassified as a wxGUI bug.
> > >
> > > Output raster options with
> > > {{{
> > > opt->gisprompt = "new,cell,raster";
> > > }}}
> > > should not be presenting the user with a list of existing maps to
choose from in the first place.
> >
> > Well, it _is_ convienient in the GUI to be able to chose an existing
map if you want to replace it...
>
> I agree, but should it then be the responsibility of the module to strip
any @mapset parts or the responsibility of the parser? It seems that this
is a more general question that also applies to other raster as well as
vector modules.
IIUC, the problem actually comes from the use of G_legal_filename() in
these modules (r.reclass is another of them). So the question is: should
modules check for legality of given file names ? And if yes, should they
use G_legal_filename(). And if yes, should G_legal_filename() check for
fully qualified names ?
Moritz
--
Ticket URL: <http://trac.osgeo.org/grass/ticket/676#comment:6>
GRASS GIS <http://grass.osgeo.org>
More information about the grass-dev
mailing list