[GRASS-dev] Re: Raster lib in GRASS7

[Glynn Clements]

Martin Landa wrote:

> I have moved selected fns from gislib to the new rasterlib. The list
> is very initial (some fns should be renamed, removed, etc.), I fixed
> also the modules to be compiled. The GIS and Raster library need to be
> clean up. The current stage is very initial.
> 
> I am not sure if G__ structure from G.h should be completely
> initialized by GIS or Raster library or the structures from G.h should
> be split and initialized separately by both libraries?

As you've noticed, the latter was done.

However, the global change of G_set_window() to Rast_set_window() in
r38009 is wrong.

Rast_set_window() updates the raster window and the column mapping for
open rasters. It doesn't affect G__.window, which is used by
G_window_{rows,cols}() etc.

Some of the code which used G_set_window() will need to continue using
G_set_window(), some of it will need to use Rast_set_window(), and
some of it will need to call both.

Right now, I suspect that many (or even most) modules which used
G_set_window() are broken.

-- 
Glynn Clements <glynn at gclements.plus.com>