[GRASS-dev] [GRASS GIS] #2314: output r.out.xyz

GRASS GIS trac at osgeo.org
Sat May 31 01:58:05 PDT 2014


#2314: output r.out.xyz
-------------------------------------------------+--------------------------
 Reporter:  pvanbosgeo                           |       Owner:  grass-dev@…              
     Type:  defect                               |      Status:  new                      
 Priority:  normal                               |   Milestone:  7.0.0                    
Component:  Default                              |     Version:  svn-trunk                
 Keywords:  separator, pipe, r.out.xyz, r.stats  |    Platform:  MSWindows 7              
      Cpu:  All                                  |  
-------------------------------------------------+--------------------------

Comment(by hcho):

 Replying to [comment:16 glynn]:
 > It adds a few new ones, namely that Python scripts (which don't use
 G_option_to_separator()) are now trying to use the literal string "pipe"
 as a separator. E.g.
 > {{{
 > $ echo "170.510125 -45.868537" | m.proj -i input=-
 > WARNING: Invalid field separator, using 'p'
 > WARNING: Invalid field separator, using 'p'
 > -4813902.92p-9497864.79p0.00
 > }}}
 >
 > G_OPT_F_SEP is used in r.out.xyz, v.in.lines, r.tileset and m.proj.
 >
 > r.out.xyz shouldn't be a problem, as the option is simply being passed
 through to r.stats.
 >
 > The other three all use the option value.
 >
 > v.in.lines and m.proj explicitly understand space, tab and comma
 (although I'm not sure that they interpret tab correctly; they appear to
 treat it as a synonym for space).
 >
 > r.tileset doesn't understand any of the names, interpreting the value
 literally.
 >

 I overlooked that some scripts use answers literally. Their default answer
 just happened to be "|", not "comma", or some other strings, so we didn't
 notice this issue so far.

 > Also, none of this changes the fact that there appears to be a bug
 somewhere. There '''shouldn't''' be any problems with using a literal
 vertical bar character. If there are such problems, they should be fixed,
 not simply worked around so that we can pretend there isn't a problem.
 >

 I agree if it can be fixed. E.g., the user can use "|", not "pipe" in the
 wxGUI console. The backtick issue was worked around because it couldn't be
 fixed (?) in Windows.

 > While there are valid reasons for supporting "separator=pipe" (e.g. not
 forcing users to understand how quoting/escaping works in their preferred
 shell),

 That very reason was why I chose to add "pipe" and as a side effect, this
 issue was partially "taken care of".

 > if it results in the original problem being forgotten about, it may need
 to be reverted until the problem is fixed.

 What about implementing grass.option_to_separator and keeping this ticket
 open until the original issue is fixed?

-- 
Ticket URL: <http://trac.osgeo.org/grass/ticket/2314#comment:17>
GRASS GIS <http://grass.osgeo.org>



More information about the grass-dev mailing list