[GRASS-dev] r.in.pdal

[Vaclav Petras]

I'm putting the conversation back on mailing, I hope that alright.

On Wed, Aug 8, 2018, 1:40 AM Anika Bettge <bettge at mundialis.de> wrote:

> Hi Vaclav,
>
> I used the pep8 tool. I get two different informations:
>
>    1. E265 block comment should start with '# '
>    when I use '# %' instead of '#%'  then are my parameter not valid,
>    e.g. "FEHLER: r.in.pdal: Sorry, <input> is not a valid parameter"
>
>
These are exception, you have to keep them as they are. See the page I
linked for info on how to silence them (I usually just leave them on).

>
>    1. E501 line too long (537 > 150 characters)
>    This is in the description of the method parameter and I do not know
>    how to write these in more than one line.
>
>
In the description that's again a special case.

>
>
> Do you know how I can solve these style problems?
>

If you would use some other tools than just pep8, I'm often using pylint,
you will get a lot messages and you need to decide which are relevant. The
main point here is to minimize them so that the code is as standardized as
possible (and thus hopefully more readable).

I hope this clarifies that,
Vaclav

> Best regards,
>
> Anika
>
>
>
> Am 08.08.2018 um 03:57 schrieb Vaclav Petras:
>
> Hi Anika,
>
> I'm glad to finally see this module; now I'm testing it. Please review the
> code and the submission guidelines. Basically it boils down to "use pep8
> tool." See the following for details.
>
> https://trac.osgeo.org/grass/wiki/Submitting/Python#Style
>
> To improve it even more, you can use lower_case_with_underscores (aka
> snake_case) instead of CamelCase/camelCase for variables and functions.
>
> Thank you,
> Vaclav
>
> On Mon, Aug 6, 2018 at 6:50 AM, Markus Metz <markus.metz.giswork at gmail.com
> > wrote:
>
>>
>>
>> 2018-08-06 12:12 GMT+02:00 Anika Bettge <bettge at mundialis.de>:
>> >
>> > Hi all,
>> >
>> > I just uploaded my first GRASS GIS addon r.in.pdal:
>> >
>> > https://trac.osgeo.org/grass/browser/grass-addons/grass7/
>> raster/r.in.pdal.
>>
>> Thanks a lot to your contribution Anika!
>>
>> A few cosmetic suggestions:
>>
>> the print command in L268 should be replaced with grass.message because
>> this is not shell-style output
>> L353:
>>         grass.message(_("Generating output raster map <%s>...") % outfile)
>> seems to be at the wrong place because nothing happens after that message
>> same for L191
>>
>> you can you set the metadata on the resultant output raster with
>> r.support, otherwise metadata will be set by r.in.xyz (the module that
>> actually created the raster)
>>
>> there are some comments on gdalwarp, but gdalwarp is not used by r.in.pdal
>>
>> Best,
>>
>> Markus M
>>
>> >
>> >
>> > Best regards,
>> > Anika
>> >
>> > --
>> >
>> >   Anika Bettge
>> >   - Anwendungsentwicklerin -
>> >
>> >   mundialis GmbH & Co. KG
>> >   Kölnstraße 99
>> >   53111 Bonn
>> >
>> >   Tel: +49 (0)228 / 38 75 80 -80
>> >   Fax: +49 (0)228 / 96 28 99 -57
>> >
>> >   Email: bettge at mundialis.de
>> >   Web: https://www.mundialis.de
>> >
>> >   Amtsgericht Bonn, HRA 8528
>> >   Komplementärin: mundialis Verwaltungsgesellschaft mbH
>> >   vertreten durch: Dr. Markus Neteler, Hinrich Paulsen, Till Adams
>> >
>> >   Informationen über Ihre gespeicherten Daten finden Sie auf unserer
>> Homepage unter folgendem Link:
>> >   https://www.mundialis.de/datenschutzerklaerung
>> >
>> > _______________________________________________
>> > grass-dev mailing list
>> > grass-dev at lists.osgeo.org
>> > https://lists.osgeo.org/mailman/listinfo/grass-dev
>>
>>
>> _______________________________________________
>> grass-dev mailing list
>> grass-dev at lists.osgeo.org
>> https://lists.osgeo.org/mailman/listinfo/grass-dev
>>
>
>
> --
>
>   Anika Bettge
>   - Anwendungsentwicklerin -
>
>   mundialis GmbH & Co. KG
>   Kölnstraße 99
>   53111 Bonn
>
>   Tel: +49 (0)228 / 38 75 80 -80
>   Fax: +49 (0)228 / 96 28 99 -57
>
>   Email: bettge at mundialis.de
>   Web: https://www.mundialis.de
>
>   Amtsgericht Bonn, HRA 8528
>   Komplementärin: mundialis Verwaltungsgesellschaft mbH
>   vertreten durch: Dr. Markus Neteler, Hinrich Paulsen, Till Adams
>
>   Informationen über Ihre gespeicherten Daten finden Sie auf unserer Homepage unter folgendem Link:
>   https://www.mundialis.de/datenschutzerklaerung
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osgeo.org/pipermail/grass-dev/attachments/20180808/0655bc00/attachment.html>