[GRASS-dev] [release planning] GRASS GIS 7.8.0 with Python3 support

[Sebastiaan Couwenberg]

On 9/5/19 12:15 PM, Martin Landa wrote:
> čt 5. 9. 2019 v 11:56 odesílatel Sebastiaan Couwenberg
> <sebastic at xs4all.nl> napsal:
>> There is still an issue with g.extension using svn export in
>> download_source_code_official_github():
>>
>>  https://github.com/OSGeo/grass/blob/releasebranch_7_8/scripts/g.extension/g.extension.py#L1094
>>
>> REQUIREMENTS.html also only documents git as a dependency for g.extension:
> 
> that's wrong, g.extension is using 'svn export' (for official repo).

Using `svn export` for git repositories makes no sense/is a horrible hack.

>>  https://github.com/OSGeo/grass/blob/releasebranch_7_8/REQUIREMENTS.html#L210
>>
>> But g.extension also uses svn in download_source_code_svn():
>>
>>  https://github.com/OSGeo/grass/blob/releasebranch_7_8/scripts/g.extension/g.extension.py#L1066
> 
> download_source_code_svn() is used only when source is 'svn' [1].
> Let's imagine that user/company has own repository with addons
> maintained by svn.

Hence the need for REQUIREMENTS.html to list both git & subversion for
g.extension.

> Note that for 'official' source (which is now
> https://github.com/osgeo/grass-addons) [2] is used
> download_source_code_official_github() which is based on 'svn export'
> instead of 'git' [3]. With git the whole repository would need to be
> cloned with full history and all addons modules. That's something we
> would like to avoid. With github 'svn export' trick do the job. Only
> single addons (directory) [which is requested by the user to be
> installed] can be fetched. I hope that we will find better solution in
> the future.

As mentioned in the thread on the pkg-grass-devel lists [0], use shallow
clone.

[0]
https://alioth-lists.debian.net/pipermail/pkg-grass-devel/2019-August/079643.html

Kind Regards,

Bas

-- 
 GPG Key ID: 4096R/6750F10AE88D4AF1
Fingerprint: 8182 DE41 7056 408D 6146  50D1 6750 F10A E88D 4AF1