[GRASS-dev] [GRASS GIS] #3880: update/drop revision check after git switch

[GRASS GIS]

#3880: update/drop revision check after git switch
------------------------+---------------------------------
  Reporter:  hellik     |      Owner:  grass-dev@…
      Type:  defect     |     Status:  reopened
  Priority:  blocker    |  Milestone:  7.8.3
 Component:  Compiling  |    Version:  svn-releasebranch76
Resolution:             |   Keywords:  svn, git, revision
       CPU:  All        |   Platform:  All
------------------------+---------------------------------

Comment (by mmetz):

 Replying to [comment:8 neteler]:
 > Replying to [comment:7 mmetz]:
 > > We could instead use GRASS_VERSION_STRING from include/version.h to
 catch the obvious cases: module x as been compiled against GRASS 7.y and
 is attempted to be used with GRASS 7.z.
 >
 > This sounds good to me.
 OK
 >
 > (of course the "docker/alpine/alpine-py38-gisinit.patch" in
 https://github.com/OSGeo/grass/pull/278 can then be removed)

 This patch does not solve problems, it masks problems because no errors
 occur in GRASS core, only when compiling certain addons.

 The patch in PR278 for gisinit.c is masking a more serious problem with
 ctypes generated for Python 3.8: the string "$Revision$" is truncated to
 its first character "$", then "$" is compared to "$Revision$" which fails
 of course. Such truncations of strings to their first character must occur
 elsewhere too, which will only become apparent at a later stage when
 executing a Python module that uses ctypes, probably causing fairly
 cryptic errors.

 Which parts of this description need to be elaborated?

-- 
Ticket URL: <https://trac.osgeo.org/grass/ticket/3880#comment:9>
GRASS GIS <https://grass.osgeo.org>