[GRASS-QA] SOCCER LAB GRASS QA: 4 clones ( Dscreen.c list.c get_row.c get_row.c put_row.c put_row.c vect.c areas.c ) 0 monsters and 0 warnings

cvs at proxy.soccerlab.polymtl.ca cvs at proxy.soccerlab.polymtl.ca
Tue Jun 13 05:58:46 EDT 2006


Hello brad,

here a report on your recent GRASS-CVS change:

ANALYSIS

your changes to files/functions:


raster/r.to.vect/areas.c functions


extract_areas (Begins at: 106 Ends at: 152)
--------------+---------+-------+---------+
Complexity:   |       6 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |      14 |       |      OK |
LOC:          |      47 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

update_list (Begins at: 160 Ends at: 320)
--------------+---------+-------+---------+
Complexity:   |      12 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |      33 |     * |         |
LOC:          |     161 |     * |         |
--------------+---------+-------+---------+
metrics are OK

end_vline (Begins at: 325 Ends at: 333)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       1 |       |      OK |
LOC:          |       9 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

end_hline (Begins at: 335 Ends at: 343)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       1 |       |      OK |
LOC:          |       9 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

start_vline (Begins at: 348 Ends at: 360)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       2 |       |      OK |
LOC:          |      13 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

start_hline (Begins at: 362 Ends at: 374)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       2 |       |      OK |
LOC:          |      13 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

get_ptr (Begins at: 378 Ends at: 415)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       1 |       |      OK |
LOC:          |      38 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

nabors (Begins at: 417 Ends at: 475)
--------------+---------+-------+---------+
Complexity:   |      12 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       0 |       |      OK |
LOC:          |      59 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

read_next (Begins at: 479 Ends at: 488)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       1 |       |      OK |
LOC:          |      10 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

alloc_areas_bufs (Begins at: 493 Ends at: 518)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       5 |       |      OK |
LOC:          |      26 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

equiv_areas (Begins at: 523 Ends at: 590)
--------------+---------+-------+---------+
Complexity:   |      12 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       7 |       |      OK |
LOC:          |      68 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

map_area (Begins at: 592 Ends at: 621)
--------------+---------+-------+---------+
Complexity:   |       3 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       2 |       |      OK |
LOC:          |      30 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

add_to_list (Begins at: 625 Ends at: 658)
--------------+---------+-------+---------+
Complexity:   |       4 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       2 |       |      OK |
LOC:          |      34 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

assign_area (Begins at: 663 Ends at: 676)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       1 |       |      OK |
LOC:          |      14 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

more_areas (Begins at: 680 Ends at: 695)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       1 |       |      OK |
LOC:          |      16 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

more_equivs (Begins at: 699 Ends at: 714)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       1 |       |      OK |
LOC:          |      16 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

update_width (Begins at: 717 Ends at: 744)
--------------+---------+-------+---------+
Complexity:   |       5 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       2 |       |      OK |
LOC:          |      28 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

Clone analysis:

This file has 4 potentially cloned functions:
  more_equivs  more_areas  start_hline  start_vline

In raster/r.to.vect/areas.c clones of  start_vline are:
	raster/r.to.vect/areas.c  start_hline

In raster/r.to.vect/areas.c clones of  more_areas are:
	raster/r.to.vect/areas.c  more_equivs

In raster/r.to.vect/areas.c clones of  more_equivs are:
	raster/r.to.vect/areas.c  more_areas

In raster/r.to.vect/areas.c clones of  start_hline are:
	raster/r.to.vect/areas.c  start_vline


__________________________________________

Threshold GRASS6 key metrics values at 2006-06-13 are:
---------------------------+-----------+---------+
                    median | upper     | outlier |
                           | quartile  | limit   |
---------------------------+-----------+---------+
Complexity (Cyclo):      5 |        25 |      37 |
ParamNBR:                2 |         6 |       8 |
CalledNBR:               9 |        55 |      79 |
LOC:                    40 |       180 |     252 |
---------------------------+-----------+---------+

Measures (see below Web page for details):
 Complexity (Cyclo): a complexity index
 ParamNBR: number of passed parameters
 CalledNBR: number of called functions
 LOC: Lines Of Code

Message interpretation:
 OK : Nothing to say at all
 *  : above 75 % of value warning
 ** : this is getting close to be out of range, consider revising the code
 ***: this is a monster, definitely you should revise this function


__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html




More information about the grass-qa mailing list