[GRASS-QA] SOCCER LAB GRASS QA: 2 clones ( Dscreen.c list.c get_row.c get_row.c put_row.c put_row.c vect.c areas.c draw.c position.c get_row.c pad.c main.c main.c command.c parser.c GS2.c gethead.c ) 1 monsters and 0 warnings

[cvs at proxy.soccerlab.polymtl.ca]

Hello glynn,

here a report on your recent GRASS-CVS change:

ANALYSIS

your changes to files/functions:


raster/r.in.arc/gethead.c functions


gethead (Begins at: 15 Ends at: 105)
--------------+---------+-------+---------+
Complexity:   |      17 |     * |         |
ParamNBR:     |       3 |       |      OK |
CalledNBR:    |      28 |       |      OK |
LOC:          |      91 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

scan_int (Begins at: 107 Ends at: 121)
--------------+---------+-------+---------+
Complexity:   |       4 |       |      OK |
ParamNBR:     |       3 |       |      OK |
CalledNBR:    |       1 |       |      OK |
LOC:          |      15 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

scan_res (Begins at: 123 Ends at: 137)
--------------+---------+-------+---------+
Complexity:   |       4 |       |      OK |
ParamNBR:     |       3 |       |      OK |
CalledNBR:    |       1 |       |      OK |
LOC:          |      15 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

scan_easting (Begins at: 140 Ends at: 143)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       3 |       |      OK |
CalledNBR:    |       1 |       |      OK |
LOC:          |       4 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

scan_northing (Begins at: 145 Ends at: 148)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       3 |       |      OK |
CalledNBR:    |       1 |       |      OK |
LOC:          |       4 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

scan_cellsize (Begins at: 150 Ends at: 153)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       3 |       |      OK |
CalledNBR:    |       1 |       |      OK |
LOC:          |       4 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

extract (Begins at: 155 Ends at: 172)
--------------+---------+-------+---------+
Complexity:   |       3 |       |      OK |
ParamNBR:     |       9 |   *** | MONSTER |
CalledNBR:    |       7 |       |      OK |
LOC:          |      18 |       |      OK |
--------------+---------+-------+---------+
1 metric are OUT OF RANGE!

missing (Begins at: 174 Ends at: 181)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       2 |       |      OK |
LOC:          |       8 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

error (Begins at: 183 Ends at: 196)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       3 |       |      OK |
LOC:          |      14 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

Clone analysis:

This file has 2 potentially cloned functions:
  scan_res  scan_int

In raster/r.in.arc/gethead.c clones of  scan_int are:
	raster/r.in.arc/gethead.c  scan_res

In raster/r.in.arc/gethead.c clones of  scan_res are:
	raster/r.in.arc/gethead.c  scan_int


__________________________________________

Threshold GRASS6 key metrics values at 2006-06-13 are:
---------------------------+-----------+---------+
                    median | upper     | outlier |
                           | quartile  | limit   |
---------------------------+-----------+---------+
Complexity (Cyclo):      5 |        25 |      37 |
ParamNBR:                2 |         6 |       8 |
CalledNBR:               9 |        55 |      79 |
LOC:                    40 |       180 |     252 |
---------------------------+-----------+---------+

Measures (see below Web page for details):
 Complexity (Cyclo): a complexity index
 ParamNBR: number of passed parameters
 CalledNBR: number of called functions
 LOC: Lines Of Code

Message interpretation:
 OK : Nothing to say at all
 *  : above 75 % of value warning
 ** : this is getting close to be out of range, consider revising the code
 ***: this is a monster, definitely you should revise this function


__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html