[GRASS-QA] GRASS QA: markus | ./grass6/raster/r.le/r.le.setup/setup.c |no clones | 0 monsters | 3 warnings

[grass-qa at proxy.soccerlab.polymtl.ca]

Hello markus,

here a report on your recent GRASS-CVS change:

ANALYSIS

your changes to files/functions:


raster/r.le/r.le.setup/setup.c functions


change_draw (Begins at: 44 Ends at: 90)
--------------+---------+-------+---------+
Complexity:   |      15 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |      42 |     * |         |
LOC:          |      47 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

set_map (Begins at: 96 Ends at: 235)
--------------+---------+-------+---------+
Complexity:   |      14 |       |      OK |
ParamNBR:     |       8 |    ** | Warning |
CalledNBR:    |      41 |     * |         |
LOC:          |     140 |     * |         |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code

paint_map (Begins at: 243 Ends at: 271)
--------------+---------+-------+---------+
Complexity:   |       3 |       |      OK |
ParamNBR:     |       3 |       |      OK |
CalledNBR:    |      10 |       |      OK |
LOC:          |      29 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

set_rgn (Begins at: 273 Ends at: 428)
--------------+---------+-------+---------+
Complexity:   |      19 |     * |         |
ParamNBR:     |       4 |       |      OK |
CalledNBR:    |      55 |     * |         |
LOC:          |     156 |     * |         |
--------------+---------+-------+---------+
metrics are OK

set_frame (Begins at: 435 Ends at: 510)
--------------+---------+-------+---------+
Complexity:   |       4 |       |      OK |
ParamNBR:     |       5 |     * |         |
CalledNBR:    |      25 |       |      OK |
LOC:          |      76 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

ppoint (Begins at: 512 Ends at: 537)
--------------+---------+-------+---------+
Complexity:   |       4 |       |      OK |
ParamNBR:     |       4 |       |      OK |
CalledNBR:    |       4 |       |      OK |
LOC:          |      26 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

pbutton (Begins at: 545 Ends at: 554)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       4 |       |      OK |
LOC:          |      10 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

save_rgn (Begins at: 562 Ends at: 634)
--------------+---------+-------+---------+
Complexity:   |       4 |       |      OK |
ParamNBR:     |       8 |    ** | Warning |
CalledNBR:    |      27 |       |      OK |
LOC:          |      73 |       |      OK |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code

print_hd (Begins at: 636 Ends at: 656)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       6 |       |      OK |
LOC:          |      21 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

scr_cell (Begins at: 658 Ends at: 671)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       6 |     * |         |
CalledNBR:    |       0 |       |      OK |
LOC:          |      14 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

change_color (Begins at: 673 Ends at: 780)
--------------+---------+-------+---------+
Complexity:   |      20 |     * |         |
ParamNBR:     |       3 |       |      OK |
CalledNBR:    |      63 |    ** | Warning |
LOC:          |     108 |       |      OK |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code

Clone analysis:

This file does not contain  cloned functions

__________________________________________

Threshold GRASS6 key metrics values at 2006-10-11 are:
---------------------------+-----------+---------+
                    median | upper     | outlier |
                           | quartile  | limit   |
---------------------------+-----------+---------+
Complexity (Cyclo):      5 |        25 |      37 |
ParamNBR:                2 |         6 |       8 |
CalledNBR:              10 |        60 |      85 |
LOC:                    41 |       189 |     264 |
---------------------------+-----------+---------+

Measures (see below Web page for details):
 Complexity (Cyclo): a complexity index
 ParamNBR: number of passed parameters
 CalledNBR: number of called functions
 LOC: Lines Of Code

Message interpretation:
 OK : Nothing to say at all
 *  : above 75 % of value warning
 ** : this is getting close to be out of range, consider revising the code
 ***: this is a monster, definitely you should revise this function


__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html