[GRASS-QA] GRASS QA: jachym | ./grass6/raster/r.fill.dir/resolve.c |2 clones ( resolve.c )| 1 monsters | 0 warnings

[grass-qa at proxy.soccerlab.polymtl.ca]

Hello jachym,

here a report on your recent GRASS-CVS change:

ANALYSIS

your changes to files/functions:


raster/r.fill.dir/resolve.c functions


select_dir (Begins at: 7 Ends at: 31)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       0 |       |      OK |
LOC:          |      25 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

flink (Begins at: 33 Ends at: 89)
--------------+---------+-------+---------+
Complexity:   |      12 |       |      OK |
ParamNBR:     |       9 |   *** | MONSTER |
CalledNBR:    |       2 |       |      OK |
LOC:          |      57 |       |      OK |
--------------+---------+-------+---------+
1 metric are OUT OF RANGE!

resolve (Begins at: 91 Ends at: 209)
--------------+---------+-------+---------+
Complexity:   |      12 |       |      OK |
ParamNBR:     |       3 |       |      OK |
CalledNBR:    |      30 |       |      OK |
LOC:          |     119 |     * |         |
--------------+---------+-------+---------+
metrics are OK

Clone analysis:

This file has 2 potentially cloned functions:
  select_dir  flink

In raster/r.fill.dir/resolve.c clones of  select_dir are:
	raster/r.drain/resolve.c  select_dir

In raster/r.fill.dir/resolve.c clones of  flink are:
	raster/r.drain/resolve.c  flink


__________________________________________

Threshold GRASS6 key metrics values at 2006-10-19 are:
---------------------------+-----------+---------+
                    median | upper     | outlier |
                           | quartile  | limit   |
---------------------------+-----------+---------+
Complexity (Cyclo):      5 |        25 |      37 |
ParamNBR:                2 |         6 |       8 |
CalledNBR:              10 |        60 |      85 |
LOC:                    41 |       189 |     265 |
---------------------------+-----------+---------+

Measures (see below Web page for details):
 Complexity (Cyclo): a complexity index
 ParamNBR: number of passed parameters
 CalledNBR: number of called functions
 LOC: Lines Of Code

Message interpretation:
 OK : Nothing to say at all
 *  : above 75 % of value warning
 ** : this is getting close to be out of range, consider revising the code
 ***: this is a monster, definitely you should revise this function


__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html