[GRASS-QA] GRASS QA: soeren | ./grass6/lib/gpde/N_les_assemble.c |no clones | 4 monsters | 3 warnings

grass-qa at proxy.soccerlab.polymtl.ca grass-qa at proxy.soccerlab.polymtl.ca
Fri Apr 6 13:29:51 EDT 2007



Hello soeren,

here a report on your recent GRASS-CVS change:

ANALYSIS

your changes to files/functions:


lib/gpde/N_les_assemble.c functions


N_alloc_5star (Begins at: 30 Ends at: 44)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       0 |       |      OK |
CalledNBR:    |       1 |       |      OK |
LOC:          |      15 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

N_alloc_7star (Begins at: 46 Ends at: 63)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       0 |       |      OK |
CalledNBR:    |       1 |       |      OK |
LOC:          |      18 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

N_alloc_9star (Begins at: 65 Ends at: 82)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       0 |       |      OK |
CalledNBR:    |       1 |       |      OK |
LOC:          |      18 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

N_alloc_27star (Begins at: 84 Ends at: 104)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       0 |       |      OK |
CalledNBR:    |       1 |       |      OK |
LOC:          |      21 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

N_create_5star (Begins at: 106 Ends at: 139)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       6 |     * |         |
CalledNBR:    |       2 |       |      OK |
LOC:          |      34 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

N_create_7star (Begins at: 141 Ends at: 180)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       8 |    ** | Warning |
CalledNBR:    |       2 |       |      OK |
LOC:          |      40 |       |      OK |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code

N_create_9star (Begins at: 182 Ends at: 243)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |      10 |   *** | MONSTER |
CalledNBR:    |       2 |       |      OK |
LOC:          |      62 |       |      OK |
--------------+---------+-------+---------+
1 metric are OUT OF RANGE!

N_create_27star (Begins at: 245 Ends at: 319)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |      28 |   *** | MONSTER |
CalledNBR:    |       4 |       |      OK |
LOC:          |      75 |       |      OK |
--------------+---------+-------+---------+
1 metric are OUT OF RANGE!

N_set_les_callback_3d_func (Begins at: 322 Ends at: 336)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       0 |       |      OK |
LOC:          |      15 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

N_set_les_callback_2d_func (Begins at: 339 Ends at: 354)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       0 |       |      OK |
LOC:          |      16 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

N_alloc_les_callback_3d (Begins at: 356 Ends at: 374)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       0 |       |      OK |
CalledNBR:    |       1 |       |      OK |
LOC:          |      19 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

N_alloc_les_callback_2d (Begins at: 376 Ends at: 409)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       0 |       |      OK |
CalledNBR:    |       1 |       |      OK |
LOC:          |      34 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

N_assemble_les_3d (Begins at: 411 Ends at: 745)
--------------+---------+-------+---------+
Complexity:   |      39 |   *** | MONSTER |
ParamNBR:     |       6 |     * |         |
CalledNBR:    |      47 |     * |         |
LOC:          |     335 |   *** | MONSTER |
--------------+---------+-------+---------+
2 metric are OUT OF RANGE!

N_assemble_les_2d (Begins at: 747 Ends at: 985)
--------------+---------+-------+---------+
Complexity:   |      28 |    ** | Warning |
ParamNBR:     |       6 |     * |         |
CalledNBR:    |      37 |     * |         |
LOC:          |     239 |    ** | Warning |
--------------+---------+-------+---------+
at least 2 values are close to an outlier please consider revising code

N_callback_template_3d (Begins at: 987 Ends at: 1024)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       5 |     * |         |
CalledNBR:    |       2 |       |      OK |
LOC:          |      38 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

N_callback_template_2d (Begins at: 1026 Ends at: 1042)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       4 |       |      OK |
CalledNBR:    |       2 |       |      OK |
LOC:          |      17 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

Clone analysis:

This file does not contain  cloned functions

__________________________________________

Threshold GRASS6 key metrics values at 2007-04-06 are:
---------------------------+-----------+---------+
                    median | upper     | outlier |
                           | quartile  | limit   |
---------------------------+-----------+---------+
Complexity (Cyclo):      5 |        25 |      37 |
ParamNBR:                2 |         6 |       8 |
CalledNBR:              10 |        60 |      87 |
LOC:                    43 |       195 |     272 |
---------------------------+-----------+---------+

Measures (see below Web page for details):
 Complexity (Cyclo): a complexity index
 ParamNBR: number of passed parameters
 CalledNBR: number of called functions
 LOC: Lines Of Code

Message interpretation:
 OK : Nothing to say at all
 *  : above 75 % of value warning
 ** : this is getting close to be out of range, consider revising the code
 ***: this is a monster, definitely you should revise this function


__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html




More information about the grass-qa mailing list