[GRASS-QA] GRASS QA: glynn | ./grass6/lib/gis/color_rule.c |3 clones ( main.c main.c ask.c cats.c color_get.c color_rule.c )| 3 monsters | 8 warnings

[grass-qa at proxy.soccerlab.polymtl.ca]

Hello glynn,

here a report on your recent GRASS-CVS change:

ANALYSIS

your changes to files/functions:


lib/gis/color_rule.c functions


G_add_d_raster_color_rule (Begins at: 33 Ends at: 60)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       9 |   *** | MONSTER |
CalledNBR:    |       1 |       |      OK |
LOC:          |      28 |       |      OK |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code

G_add_f_raster_color_rule (Begins at: 63 Ends at: 86)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       9 |   *** | MONSTER |
CalledNBR:    |       1 |       |      OK |
LOC:          |      24 |       |      OK |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code

G_add_c_raster_color_rule (Begins at: 89 Ends at: 118)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       9 |   *** | MONSTER |
CalledNBR:    |       1 |       |      OK |
LOC:          |      30 |       |      OK |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code

G_add_raster_color_rule (Begins at: 121 Ends at: 163)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |      10 |   *** | MONSTER |
CalledNBR:    |       1 |       |      OK |
LOC:          |      43 |       |      OK |
--------------+---------+-------+---------+
1 metric are OUT OF RANGE!

G_add_color_rule (Begins at: 166 Ends at: 171)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       9 |   *** | MONSTER |
CalledNBR:    |       1 |       |      OK |
LOC:          |       6 |       |      OK |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code

G_add_modular_d_raster_color_rule (Begins at: 174 Ends at: 187)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       9 |   *** | MONSTER |
CalledNBR:    |       1 |       |      OK |
LOC:          |      14 |       |      OK |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code

G_add_modular_f_raster_color_rule (Begins at: 190 Ends at: 203)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       9 |   *** | MONSTER |
CalledNBR:    |       1 |       |      OK |
LOC:          |      14 |       |      OK |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code

G_add_modular_c_raster_color_rule (Begins at: 206 Ends at: 209)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       9 |   *** | MONSTER |
CalledNBR:    |       1 |       |      OK |
LOC:          |       4 |       |      OK |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code

G_add_modular_raster_color_rule (Begins at: 212 Ends at: 225)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |      10 |   *** | MONSTER |
CalledNBR:    |       1 |       |      OK |
LOC:          |      14 |       |      OK |
--------------+---------+-------+---------+
1 metric are OUT OF RANGE!

G_add_modular_color_rule (Begins at: 228 Ends at: 241)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       9 |   *** | MONSTER |
CalledNBR:    |       1 |       |      OK |
LOC:          |      14 |       |      OK |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code

add_color_rule (Begins at: 243 Ends at: 382)
--------------+---------+-------+---------+
Complexity:   |      28 |    ** | Warning |
ParamNBR:     |      13 |   *** | MONSTER |
CalledNBR:    |      11 |       |      OK |
LOC:          |     140 |     * |         |
--------------+---------+-------+---------+
1 metric are OUT OF RANGE!

Clone analysis:

This file has 3 potentially cloned functions:
  G_add_modular_color_rule  G_add_modular_f_raster_color_rule  G_add_modular_d_raster_color_rule

In lib/gis/color_rule.c clones of  G_add_modular_d_raster_color_rule are:
	lib/gis/color_rule.c  G_add_modular_color_rule
	lib/gis/color_rule.c  G_add_modular_f_raster_color_rule

In lib/gis/color_rule.c clones of  G_add_modular_color_rule are:
	lib/gis/color_rule.c  G_add_modular_f_raster_color_rule
	lib/gis/color_rule.c  G_add_modular_d_raster_color_rule

In lib/gis/color_rule.c clones of  G_add_modular_f_raster_color_rule are:
	lib/gis/color_rule.c  G_add_modular_color_rule
	lib/gis/color_rule.c  G_add_modular_d_raster_color_rule


__________________________________________

Threshold GRASS6 key metrics values at 2007-04-13 are:
---------------------------+-----------+---------+
                    median | upper     | outlier |
                           | quartile  | limit   |
---------------------------+-----------+---------+
Complexity (Cyclo):      5 |        25 |      37 |
ParamNBR:                2 |         6 |       9 |
CalledNBR:              10 |        60 |      87 |
LOC:                    43 |       195 |     272 |
---------------------------+-----------+---------+

Measures (see below Web page for details):
 Complexity (Cyclo): a complexity index
 ParamNBR: number of passed parameters
 CalledNBR: number of called functions
 LOC: Lines Of Code

Message interpretation:
 OK : Nothing to say at all
 *  : above 75 % of value warning
 ** : this is getting close to be out of range, consider revising the code
 ***: this is a monster, definitely you should revise this function


__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html