[GRASS-QA] GRASS QA: soeren | ./grass6/lib/gpde/N_solvers_krylov.c |no clones | 0 monsters | 0 warnings

[grass-qa at proxy.soccerlab.polymtl.ca]

Hello soeren,

here a report on your recent GRASS-CVS change:

ANALYSIS

your changes to files/functions:


lib/gpde/N_solvers_krylov.c functions


N_solver_pcg (Begins at: 63 Ends at: 231)
--------------+---------+-------+---------+
Complexity:   |      10 |       |      OK |
ParamNBR:     |       3 |       |      OK |
CalledNBR:    |      33 |       |      OK |
LOC:          |     169 |     * |         |
--------------+---------+-------+---------+
metrics are OK

N_solver_cg (Begins at: 233 Ends at: 390)
--------------+---------+-------+---------+
Complexity:   |      10 |       |      OK |
ParamNBR:     |       3 |       |      OK |
CalledNBR:    |      29 |       |      OK |
LOC:          |     158 |     * |         |
--------------+---------+-------+---------+
metrics are OK

N_solver_bicgstab (Begins at: 392 Ends at: 543)
--------------+---------+-------+---------+
Complexity:   |       8 |       |      OK |
ParamNBR:     |       3 |       |      OK |
CalledNBR:    |      35 |       |      OK |
LOC:          |     152 |     * |         |
--------------+---------+-------+---------+
metrics are OK

scalar_product (Begins at: 545 Ends at: 569)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       4 |       |      OK |
CalledNBR:    |       0 |       |      OK |
LOC:          |      25 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

N_matrix_vector_product (Begins at: 571 Ends at: 597)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       3 |       |      OK |
CalledNBR:    |       0 |       |      OK |
LOC:          |      27 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

N_sparse_matrix_vector_product (Begins at: 599 Ends at: 627)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       3 |       |      OK |
CalledNBR:    |       0 |       |      OK |
LOC:          |      29 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

add_vectors_scalar2 (Begins at: 630 Ends at: 654)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       6 |     * |         |
CalledNBR:    |       0 |       |      OK |
LOC:          |      25 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

add_vectors_scalar (Begins at: 657 Ends at: 681)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       5 |     * |         |
CalledNBR:    |       0 |       |      OK |
LOC:          |      25 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

sub_vectors_scalar (Begins at: 684 Ends at: 707)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       5 |     * |         |
CalledNBR:    |       0 |       |      OK |
LOC:          |      24 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

add_vectors (Begins at: 709 Ends at: 731)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       4 |       |      OK |
CalledNBR:    |       0 |       |      OK |
LOC:          |      23 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

sub_vectors (Begins at: 733 Ends at: 755)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       4 |       |      OK |
CalledNBR:    |       0 |       |      OK |
LOC:          |      23 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

scalar_vector_product (Begins at: 757 Ends at: 775)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       4 |       |      OK |
CalledNBR:    |       0 |       |      OK |
LOC:          |      19 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

sync_vectors (Begins at: 777 Ends at: 798)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       3 |       |      OK |
CalledNBR:    |       0 |       |      OK |
LOC:          |      22 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

check_symmetry (Begins at: 800 Ends at: 871)
--------------+---------+-------+---------+
Complexity:   |       8 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       9 |       |      OK |
LOC:          |      72 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

N_create_diag_precond_matrix (Begins at: 873 Ends at: 903)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       5 |       |      OK |
LOC:          |      31 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

Clone analysis:

This file does not contain  cloned functions

__________________________________________

Threshold GRASS6 key metrics values at 2007-06-04 are:
---------------------------+-----------+---------+
                    median | upper     | outlier |
                           | quartile  | limit   |
---------------------------+-----------+---------+
Complexity (Cyclo):      5 |        25 |      37 |
ParamNBR:                2 |         6 |       9 |
CalledNBR:              10 |        60 |      87 |
LOC:                    43 |       195 |     273 |
---------------------------+-----------+---------+

Measures (see below Web page for details):
 Complexity (Cyclo): a complexity index
 ParamNBR: number of passed parameters
 CalledNBR: number of called functions
 LOC: Lines Of Code

Message interpretation:
 OK : Nothing to say at all
 *  : above 75 % of value warning
 ** : this is getting close to be out of range, consider revising the code
 ***: this is a monster, definitely you should revise this function


__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html