[GRASS-QA] GRASS QA: soeren | ./grass6/lib/gpde/N_solvers_classic_iter.c |2 clones ( N_les_assemble.c N_solvers.c N_solvers_classic_iter.c )| 0 monsters | 2 warnings

[grass-qa at proxy.soccerlab.polymtl.ca]

Hello soeren,

here a report on your recent GRASS-CVS change:

ANALYSIS

your changes to files/functions:


lib/gpde/N_solvers_classic_iter.c functions


N_solver_jacobi (Begins at: 53 Ends at: 88)
--------------+---------+-------+---------+
Complexity:   |       3 |       |      OK |
ParamNBR:     |       4 |       |      OK |
CalledNBR:    |       4 |       |      OK |
LOC:          |      36 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

N_solver_SOR (Begins at: 90 Ends at: 103)
--------------+---------+-------+---------+
Complexity:   |       3 |       |      OK |
ParamNBR:     |       4 |       |      OK |
CalledNBR:    |       4 |       |      OK |
LOC:          |      14 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

sparse_jacobi_gauss (Begins at: 109 Ends at: 165)
--------------+---------+-------+---------+
Complexity:   |       6 |       |      OK |
ParamNBR:     |       5 |     * |         |
CalledNBR:    |       9 |       |      OK |
LOC:          |      57 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

jacobi (Begins at: 170 Ends at: 203)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       7 |    ** | Warning |
CalledNBR:    |       3 |       |      OK |
LOC:          |      34 |       |      OK |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code

gauss_seidel (Begins at: 208 Ends at: 241)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       7 |    ** | Warning |
CalledNBR:    |       3 |       |      OK |
LOC:          |      34 |       |      OK |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code

Clone analysis:

This file has 2 potentially cloned functions:
  gauss_seidel  jacobi

In lib/gpde/N_solvers_classic_iter.c clones of  gauss_seidel are:
	lib/gpde/N_solvers_classic_iter.c  jacobi

In lib/gpde/N_solvers_classic_iter.c clones of  jacobi are:
	lib/gpde/N_solvers_classic_iter.c  gauss_seidel


__________________________________________

Threshold GRASS6 key metrics values at 2007-06-04 are:
---------------------------+-----------+---------+
                    median | upper     | outlier |
                           | quartile  | limit   |
---------------------------+-----------+---------+
Complexity (Cyclo):      5 |        25 |      37 |
ParamNBR:                2 |         6 |       9 |
CalledNBR:              10 |        60 |      87 |
LOC:                    43 |       195 |     273 |
---------------------------+-----------+---------+

Measures (see below Web page for details):
 Complexity (Cyclo): a complexity index
 ParamNBR: number of passed parameters
 CalledNBR: number of called functions
 LOC: Lines Of Code

Message interpretation:
 OK : Nothing to say at all
 *  : above 75 % of value warning
 ** : this is getting close to be out of range, consider revising the code
 ***: this is a monster, definitely you should revise this function


__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html